[jira] [Commented] (CASSANDRA-15459) Short read protection doesn't work on group-by queries

["Caleb Rackliffe (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-15459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170976#comment-17170976 ] 

Caleb Rackliffe commented on CASSANDRA-15459:
---------------------------------------------

[~adelapena] What's your opinion on whether the existing Python dtest would be better as an in-JVM dtest? One thing that might be nice in this case is that we could leave the trunk/4.0 version of the test in a simpler state, due to not needing the Byteman injection to avoid blocking read-repair there. Also, I think in-jvm tests would be able to run considerably faster, given they don't need to stop and start nodes. (i.e. They can write only to specific nodes w/ `executeInternal()`.)

> Short read protection doesn't work on group-by queries
> ------------------------------------------------------
>
>                 Key: CASSANDRA-15459
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15459
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Legacy/Coordination
>            Reporter: ZhaoYang
>            Assignee: Andres de la Peña
>            Priority: Normal
>              Labels: correctness
>             Fix For: 3.11.x, 4.0-beta
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> [DTest to reproduce|https://github.com/apache/cassandra-dtest/compare/master...jasonstack:srp_group_by_trunk?expand=1]: it affects all versions..
> {code}
> In a two-node cluster with RF = 2
> Execute only on Node1:
> * Insert pk=1 and ck=1 with timestamp 9
> * Delete pk=0 and ck=0 with timestamp 10
> * Insert pk=2 and ck=2 with timestamp 9
> Execute only on Node2:
> * Delete pk=1 and ck=1 with timestamp 10
> * Insert pk=0 and ck=0 with timestamp 9
> * Delete pk=2 and ck=2 with timestamp 10
> Query: "SELECT pk, c FROM %s GROUP BY pk LIMIT 1"
> * Expect no live data, but got [0, 0]
> {code}
> Note: for group-by queries, SRP should use "group counted" to calculate limits used for SRP query, rather than "row counted".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org