You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2015/10/28 00:31:34 UTC
Review Request 39706: GEODE-411: fix suspect string on disconnect
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39706/
-----------------------------------------------------------
Review request for geode and Dan Smith.
Bugs: GEODE-411
https://issues.apache.org/jira/browse/GEODE-411
Repository: geode
Description
-------
DistributionManager now has a isCloseInProgress method
that checks both the volatile closeInProgress boolean
and ask its DistributedSystem if it is disconnecting.
This new method is used in places that decide if a warning
should be logged.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionManager.java 37f355f6039ca87df72354c19b8d15945b509bf9
Diff: https://reviews.apache.org/r/39706/diff/
Testing
-------
ConnectDisconnectDUnitTest
Thanks,
Darrel Schneider
Re: Review Request 39706: GEODE-411: fix suspect string on disconnect
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39706/#review104227
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On Oct. 27, 2015, 11:31 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39706/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2015, 11:31 p.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Bugs: GEODE-411
> https://issues.apache.org/jira/browse/GEODE-411
>
>
> Repository: geode
>
>
> Description
> -------
>
> DistributionManager now has a isCloseInProgress method
> that checks both the volatile closeInProgress boolean
> and ask its DistributedSystem if it is disconnecting.
> This new method is used in places that decide if a warning
> should be logged.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionManager.java 37f355f6039ca87df72354c19b8d15945b509bf9
>
> Diff: https://reviews.apache.org/r/39706/diff/
>
>
> Testing
> -------
>
> ConnectDisconnectDUnitTest
>
>
> Thanks,
>
> Darrel Schneider
>
>