You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Johnson9009 (via GitHub)" <gi...@apache.org> on 2023/04/18 09:48:14 UTC

[GitHub] [tvm] Johnson9009 opened a new pull request, #14656: [Runtime] Fix Can't "query_imports" Bug of VM Executable

Johnson9009 opened a new pull request, #14656:
URL: https://github.com/apache/tvm/pull/14656

   This "LOG(FATAL)" will error out when the function isn't found in “executable”, so it will prevent the recursive query the function in the imported modules of "executable".
   
   For example, if the module hierarchy is something like below.
   executable
   |---LLVMModuleNode
   |___NPUModuleNode
   
   This bug will cause we can't get the function in NPUModuleNode by the call "executalbe.get_function("npu_func1", query_imports=True)".


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao merged pull request #14656: [Runtime] Fix Can't "query_imports" Bug of VM Executable

Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao merged PR #14656:
URL: https://github.com/apache/tvm/pull/14656


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #14656: [Runtime] Fix Can't "query_imports" Bug of VM Executable

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14656:
URL: https://github.com/apache/tvm/pull/14656#issuecomment-1512777156

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @areusch <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Johnson9009 commented on pull request #14656: [Runtime] Fix Can't "query_imports" Bug of VM Executable

Posted by "Johnson9009 (via GitHub)" <gi...@apache.org>.
Johnson9009 commented on PR #14656:
URL: https://github.com/apache/tvm/pull/14656#issuecomment-1512781385

   @junrushao @Hzfengsy @tqchen Please help to review, this is so little bug fix, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao commented on pull request #14656: [Runtime] Fix Can't "query_imports" Bug of VM Executable

Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao commented on PR #14656:
URL: https://github.com/apache/tvm/pull/14656#issuecomment-1513493047

   The PR looks good to me. Retriggering CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org