[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #6188: Dont start Riak in TP/TO GHA

[GitBox <gi...@apache.org>]

ocket8888 commented on a change in pull request #6188:
URL: https://github.com/apache/trafficcontrol/pull/6188#discussion_r705864145



##########
File path: .github/workflows/tp.integration.tests.yml
##########
@@ -107,6 +109,9 @@ jobs:
       - name: Initialize Traffic Ops Database
         id: todb
         uses: ./.github/actions/todb-init
+      - name: Initialize Traffic Vault Database
+        id: tvdb
+        uses: ./.github/actions/tvdb-init

Review comment:
       Could we use the same PostgreSQL instance as the TODB but just add another database? Seems like that might be faster.

##########
File path: .github/actions/to-integration-tests/cdn.json
##########
@@ -22,6 +22,20 @@
 		"max_db_connections": 20,
 		"db_conn_max_lifetime_seconds": 60,
 		"db_query_timeout_seconds": 20,
+		"traffic_vault_backend": "postgres",
+		"traffic_vault_config": {
+			"dbname": "traffic_vault",
+			"hostname": "localhost",
+			"user": "traffic_vault",
+			"password": "twelve",
+			"port": 5432,
+			"ssl": false,
+			"conn_max_lifetime_seconds": 60,
+			"max_connections": 500,
+			"max_idle_connections": 30,
+			"query_timeout_seconds": 10,
+			"aes_key_location": "/aes.key"

Review comment:
       Don't you only need this for retrieving things from a Hashicorp vault? Do the integration tests need to do that?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org