You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/20 10:55:51 UTC
[GitHub] [incubator-nuttx] easonxiang opened a new pull request, #7369: Fix armclang build warning: L6306W
easonxiang opened a new pull request, #7369:
URL: https://github.com/apache/incubator-nuttx/pull/7369
When a function is known to preserve eight-byte alignment of the stack, armclang assigns the build attribute Tag_ABI_align_preserved to that function. However, the armclang integrated assembler does not automatically assign this attribute to assembly code.
Signed-off-by: xiangdong6 <xi...@xiaomi.com>
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] easonxiang commented on a diff in pull request #7369: Fix armclang build warning: L6306W
Posted by GitBox <gi...@apache.org>.
easonxiang commented on code in PR #7369:
URL: https://github.com/apache/incubator-nuttx/pull/7369#discussion_r1001273358
##########
arch/arm/src/armv7-r/arm_vectortab.S:
##########
@@ -34,6 +34,10 @@
* Public Symbols
****************************************************************************/
+#ifdef CONFIG_ARM_TOOLCHAIN_ARMCLANG
+ .eabi_attribute Tag_ABI_align_preserved, 1
Review Comment:
> why not use PRESERVE8 https://developer.arm.com/documentation/ka003030/latest
I have tried this method, but it not works. This patch is from the armlink document.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7369: Fix armclang build warning: L6306W
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7369:
URL: https://github.com/apache/incubator-nuttx/pull/7369#discussion_r1000954717
##########
arch/arm/src/armv7-r/arm_vectortab.S:
##########
@@ -34,6 +34,10 @@
* Public Symbols
****************************************************************************/
+#ifdef CONFIG_ARM_TOOLCHAIN_ARMCLANG
+ .eabi_attribute Tag_ABI_align_preserved, 1
Review Comment:
btw, please fix armv7a too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] easonxiang commented on a diff in pull request #7369: Fix armclang build warning: L6306W
Posted by GitBox <gi...@apache.org>.
easonxiang commented on code in PR #7369:
URL: https://github.com/apache/incubator-nuttx/pull/7369#discussion_r1001273635
##########
arch/arm/src/armv7-r/arm_vectortab.S:
##########
@@ -34,6 +34,10 @@
* Public Symbols
****************************************************************************/
+#ifdef CONFIG_ARM_TOOLCHAIN_ARMCLANG
+ .eabi_attribute Tag_ABI_align_preserved, 1
Review Comment:
> btw, please fix armv7a too
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7369: Fix armclang build warning: L6306W
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7369:
URL: https://github.com/apache/incubator-nuttx/pull/7369#discussion_r1000953486
##########
arch/arm/src/armv7-r/arm_vectortab.S:
##########
@@ -34,6 +34,10 @@
* Public Symbols
****************************************************************************/
+#ifdef CONFIG_ARM_TOOLCHAIN_ARMCLANG
+ .eabi_attribute Tag_ABI_align_preserved, 1
Review Comment:
why not use PRESERVE8
https://developer.arm.com/documentation/ka003030/latest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7369: Fix armclang build warning: L6306W
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7369:
URL: https://github.com/apache/incubator-nuttx/pull/7369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org