Re: Review Request 22925: CLOUDSTACK-6236: Negative ref_cnt of template(snapshot/volume)_store_ref results in out-of-range error in Mysql

[Pierre-Luc Dion <pd...@apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22925/#review63328
-----------------------------------------------------------


Hi Hiroki, I wanted to apply your patch, but the patch file is not valid, it require your email address. There is also a conflict for the file: ``engine/schema/src/org/apache/cloudstack/storage/datastore/db/VolumeDataStoreVO.java``
Could it be possible to rebase and resubmit a new patch ? 

Thanks.

- Pierre-Luc Dion


On June 24, 2014, 5:36 a.m., Hiroki Ohashi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22925/
> -----------------------------------------------------------
> 
> (Updated June 24, 2014, 5:36 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> setRefCnt method is fixed in VolumeDataStoreVO.java by a patch of CLOUDSTACK-6236 but this may be a mistake of decrRefCnt method. This patch fixes it and add more log message.
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/org/apache/cloudstack/storage/datastore/db/SnapshotDataStoreVO.java 75b1d75 
>   engine/schema/src/org/apache/cloudstack/storage/datastore/db/TemplateDataStoreVO.java bb05300 
>   engine/schema/src/org/apache/cloudstack/storage/datastore/db/VolumeDataStoreVO.java aa57e74 
> 
> Diff: https://reviews.apache.org/r/22925/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hiroki Ohashi
> 
>