You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "majialoong (via GitHub)" <gi...@apache.org> on 2025/10/16 16:00:15 UTC
[PR] [ISSUE #9763] Fix invalid user disable status check in authorization [rocketmq]
majialoong opened a new pull request, #9764:
URL: https://github.com/apache/rocketmq/pull/9764
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
Fixes #9763
### Brief Description
The disabled status of a user should be correctly detected when the user is disabled. And correctly prompt that the user has been disabled.
### How Did You Test This Change?
When accessing the cluster with a disabled user, a prompt indicates that the user has been disabled.
<img width="905" height="218" alt="Image" src="https://github.com/user-attachments/assets/db65ba63-cdfd-4679-acf3-c6ad50c7a6f2" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #9763] Fix invalid user disable status check in authorization [rocketmq]
Posted by "majialoong (via GitHub)" <gi...@apache.org>.
majialoong commented on PR #9764:
URL: https://github.com/apache/rocketmq/pull/9764#issuecomment-3414180446
Hello, @dingshuangxi888 @lizhimins @RongtongJin , please take a look at this PR when have time, thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #9763] Fix invalid user disable status check in authorization [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #9764:
URL: https://github.com/apache/rocketmq/pull/9764#issuecomment-3411705066
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/9764?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.23%. Comparing base ([`e6ec760`](https://app.codecov.io/gh/apache/rocketmq/commit/e6ec760eaaff493041f5a61bccc71f19d7585682?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`52a67b3`](https://app.codecov.io/gh/apache/rocketmq/commit/52a67b3f9f4fad81206581691d049fd809830e26?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/rocketmq/pull/9764?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../authorization/chain/UserAuthorizationHandler.java](https://app.codecov.io/gh/apache/rocketmq/pull/9764?src=pr&el=tree&filepath=auth%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fauth%2Fauthorization%2Fchain%2FUserAuthorizationHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvYXV0aC9hdXRob3JpemF0aW9uL2NoYWluL1VzZXJBdXRob3JpemF0aW9uSGFuZGxlci5qYXZh) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/9764?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #9764 +/- ##
=============================================
- Coverage 48.33% 48.23% -0.11%
+ Complexity 12193 12170 -23
=============================================
Files 1313 1313
Lines 93340 93340
Branches 11962 11962
=============================================
- Hits 45116 45021 -95
- Misses 42656 42740 +84
- Partials 5568 5579 +11
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/9764?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #9763] Fix invalid user disable status check in authorization [rocketmq]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #9764:
URL: https://github.com/apache/rocketmq/pull/9764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org