[GitHub] [maven-jlink-plugin] bmarwell commented on a diff in pull request #78: [MJLINK-64] Fix addOptions arguments passing

[GitBox <gi...@apache.org>]

bmarwell commented on code in PR #78:
URL: https://github.com/apache/maven-jlink-plugin/pull/78#discussion_r1070024403


##########
src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java:
##########
@@ -108,6 +108,8 @@
      *
      * <p>The command line equivalent is: {@code jlink --add-options="..."}.</p>
      *
+     * Spaces in options are not supported, they will be treated as separate options.
+     *

Review Comment:
   -1, this MUST be supported.



##########
src/it/projects/cli-options/add-options/verify.groovy:
##########
@@ -25,7 +25,7 @@ import org.codehaus.plexus.util.*
 
 String buildlog = new File( basedir, "build.log").text
 assert buildlog.contains( "--add-options" )
-assert buildlog.contains( "\"-Xmx128m --enable-preview -Dvar=value\"" )
+assert buildlog.contains( "-Xmx128m --enable-preview -Dvar=value" )

Review Comment:
   To be extra safe, we could use this:
   
   ```groovy
   assert buildlog.contains("\"-Xmx128m\" \"--enable-preview\" \"-Dvar=value\"")
   ```
   
   WDYT?



##########
src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java:
##########
@@ -654,7 +656,7 @@ private List<String> createJlinkArgs( Collection<String> pathsOfModules,
         if ( addOptions != null && !addOptions.isEmpty() )
         {
             jlinkArgs.add( "--add-options" );
-            jlinkArgs.add( String.format( "\"%s\"", String.join( " ", addOptions ) ) );
+            jlinkArgs.add( String.format( "%s", String.join( " ", addOptions ) ) );

Review Comment:
   We can support that here. We would just need to iterate over `addOptions` instead, so -1 on this one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org