You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/03/09 04:53:16 UTC

[GitHub] [helix] desaikomal commented on pull request #1975: Add 3 Zookeeper CreateMode types to AccessOption

desaikomal commented on pull request #1975:
URL: https://github.com/apache/helix/pull/1975#issuecomment-1062552986


   code changes looks ok, but question - do we need to add any unit-tests to verify that we are passing those options appropriately to ZK? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org