You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by do...@apache.org on 2010/09/15 19:56:21 UTC
svn commit: r997418 -
/ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl
Author: doogie
Date: Wed Sep 15 17:56:20 2010
New Revision: 997418
URL: http://svn.apache.org/viewvc?rev=997418&view=rev
Log:
Fix incorrect id element values; change them back to what they used to
be, so they match up with the javascript. This was keeping the
addnewaddress form from popping up(it broke rather badly in IE).
Modified:
ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl
Modified: ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl?rev=997418&r1=997417&r2=997418&view=diff
==============================================================================
--- ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl (original)
+++ ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl Wed Sep 15 17:56:20 2010
@@ -315,9 +315,9 @@ under the License.
<div class="form-field"><input type="text" class="required" name="shipToPostalCode" id="postalCode" value="" size="30" maxlength="10" /></div>
</div>
<div class="form-row">
- <label for="country">${uiLabelMap.PartyCountry}* <span id="advice-required-countryGeoId" style="display: none" class="custom-advice">(required)</span></label>
+ <label for="countryGeoId">${uiLabelMap.PartyCountry}* <span id="advice-required-countryGeoId" style="display: none" class="custom-advice">(required)</span></label>
<div class="form-field">
- <select name="shipToCountryGeoId" id="country" class="required" style="width: 70%">
+ <select name="shipToCountryGeoId" id="countryGeoId" class="required" style="width: 70%">
<#if countryGeoId?exists>
<option value="${countryGeoId}">${countryGeoId}</option>
</#if>
@@ -326,9 +326,9 @@ under the License.
</div>
</div>
<div class="form-row">
- <label for="state">${uiLabelMap.PartyState}* <span id="advice-required-stateProvinceGeoId" style="display: none" class="custom-advice">(required)</span></label>
+ <label for="stateProvinceGeoId">${uiLabelMap.PartyState}* <span id="advice-required-stateProvinceGeoId" style="display: none" class="custom-advice">(required)</span></label>
<div class="form-field">
- <select name="shipToStateProvinceGeoId" id="state" style="width: 70%">
+ <select name="shipToStateProvinceGeoId" id="stateProvinceGeoId" style="width: 70%">
<#if stateProvinceGeoId?has_content>
<option value="${stateProvinceGeoId}">${stateProvinceGeoId}</option>
<#else>
Re: svn commit: r997418 - /ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl
Posted by Adam Heath <do...@brainfood.com>.
On 09/15/2010 12:56 PM, doogie@apache.org wrote:
> Author: doogie
> Date: Wed Sep 15 17:56:20 2010
> New Revision: 997418
>
> URL: http://svn.apache.org/viewvc?rev=997418&view=rev
> Log:
> Fix incorrect id element values; change them back to what they used to
> be, so they match up with the javascript. This was keeping the
> addnewaddress form from popping up(it broke rather badly in IE).
Please, please, please be careful when changing html. At the very
least, *know* what you are altering, and how it can interact with
other things. At the very least, should need to see if the html so
altered actually still functions, by clicking on any link/button, or
entering text into the fields, that are within the context of the change.
The revision that broke this(use blame/annotate) changed the element
id, but didn't change the javascript that was looking for that id.
The previous change broke the feature in *all* browsers.
Going forward, everyone should be *very* careful about changing an
*id* of an element. Even a class change should be done with caution.
>
> Modified:
> ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl
>
> Modified: ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl?rev=997418&r1=997417&r2=997418&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl (original)
> +++ ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl Wed Sep 15 17:56:20 2010
> @@ -315,9 +315,9 @@ under the License.
> <div class="form-field"><input type="text" class="required" name="shipToPostalCode" id="postalCode" value="" size="30" maxlength="10" /></div>
> </div>
> <div class="form-row">
> -<label for="country">${uiLabelMap.PartyCountry}*<span id="advice-required-countryGeoId" style="display: none" class="custom-advice">(required)</span></label>
> +<label for="countryGeoId">${uiLabelMap.PartyCountry}*<span id="advice-required-countryGeoId" style="display: none" class="custom-advice">(required)</span></label>
> <div class="form-field">
> -<select name="shipToCountryGeoId" id="country" class="required" style="width: 70%">
> +<select name="shipToCountryGeoId" id="countryGeoId" class="required" style="width: 70%">
> <#if countryGeoId?exists>
> <option value="${countryGeoId}">${countryGeoId}</option>
> </#if>
> @@ -326,9 +326,9 @@ under the License.
> </div>
> </div>
> <div class="form-row">
> -<label for="state">${uiLabelMap.PartyState}*<span id="advice-required-stateProvinceGeoId" style="display: none" class="custom-advice">(required)</span></label>
> +<label for="stateProvinceGeoId">${uiLabelMap.PartyState}*<span id="advice-required-stateProvinceGeoId" style="display: none" class="custom-advice">(required)</span></label>
> <div class="form-field">
> -<select name="shipToStateProvinceGeoId" id="state" style="width: 70%">
> +<select name="shipToStateProvinceGeoId" id="stateProvinceGeoId" style="width: 70%">
> <#if stateProvinceGeoId?has_content>
> <option value="${stateProvinceGeoId}">${stateProvinceGeoId}</option>
> <#else>
>
>