[GitHub] [flink] leonardBang commented on a diff in pull request #21198: [FLINK-29803][table] Populate Scala API source jars

[GitBox <gi...@apache.org>]

leonardBang commented on code in PR #21198:
URL: https://github.com/apache/flink/pull/21198#discussion_r1009152581


##########
flink-table/flink-table-api-scala-bridge/pom.xml:
##########
@@ -122,6 +122,42 @@ under the License.
 					</execution>
 				</executions>
 			</plugin>
+
+			<!-- Adding scala source directories to build path
+			 	 This is required for the source jar -->
+			<plugin>
+				<groupId>org.codehaus.mojo</groupId>
+				<artifactId>build-helper-maven-plugin</artifactId>
+				<executions>
+					<!-- Add src/main/scala to build path -->
+					<execution>
+						<id>add-source</id>
+						<phase>generate-sources</phase>
+						<goals>
+							<goal>add-source</goal>
+						</goals>
+						<configuration>
+							<sources>
+								<source>src/main/scala</source>
+							</sources>
+						</configuration>
+					</execution>
+					<!-- Add src/test/scala to build path -->
+					<execution>
+						<id>add-test-source</id>
+						<phase>generate-test-sources</phase>
+						<goals>
+							<goal>add-test-source</goal>
+						</goals>
+						<configuration>
+							<sources>
+								<source>src/test/java</source>

Review Comment:
   Do we need this `src/test/java` ? I though we've added them by `maven-jar-plugin:test-jar`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org