[GitHub] [drill] jnturton commented on a diff in pull request #2699: DRILL-8283: Translation of IS NOT NULL($1) is not supported by MongoProject

[GitBox <gi...@apache.org>]

jnturton commented on code in PR #2699:
URL: https://github.com/apache/drill/pull/2699#discussion_r1011758384


##########
contrib/storage-mongo/src/test/java/org/apache/drill/exec/store/mongo/TestMongoProjectPushDown.java:
##########
@@ -93,14 +93,27 @@ public void testMultipleColumnsProject() throws Exception {
 
   @Test
   public void testStarProject() throws Exception {
-    String query = String.format(TEST_QUERY_PROJECT_PUSH_DOWN__TEMPLATE_3, EMPLOYEE_DB, EMPINFO_COLLECTION);
+    String query = String.format(TEST_QUERY_PROJECT_PUSH_DOWN_TEMPLATE_3, EMPLOYEE_DB, EMPINFO_COLLECTION);
     testBuilder()
         .sqlQuery(query)
         .unOrdered()
         .expectsNumRecords(19)
         .go();
   }
 
+  // DRILL-8238
+  @Test
+  public void testOperatorsProject() throws Exception {
+    String query = String.format(TEST_QUERY_PROJECT_PUSH_DOWN_TEMPLATE_4, EMPLOYEE_DB, EMPINFO_COLLECTION);
+
+    testBuilder()
+        .sqlQuery(query)
+        .unOrdered()
+        .baselineColumns("position_id_or_default")
+        .expectsNumRecords(19)

Review Comment:
   I guess it should be possible to explicitly test whether the coalescing operator was applied successfully, not just whether the query now completes without an error.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org