You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Miles Yucht (JIRA)" <ji...@apache.org> on 2018/05/28 08:42:00 UTC

[jira] [Resolved] (SPARK-24381) Improve Unit Test Coverage of NOT IN subqueries

     [ https://issues.apache.org/jira/browse/SPARK-24381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Miles Yucht resolved SPARK-24381.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 2.3.2

This PR has merged. In adding these tests we discovered some other edge cases which are incorrect, and a follow-up issue has been filed.

> Improve Unit Test Coverage of NOT IN subqueries
> -----------------------------------------------
>
>                 Key: SPARK-24381
>                 URL: https://issues.apache.org/jira/browse/SPARK-24381
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 2.3.2
>            Reporter: Miles Yucht
>            Priority: Major
>             Fix For: 2.3.2
>
>
> Today, the unit test coverage for NOT IN queries in SubquerySuite is somewhat lacking. There are a couple test cases that exist, but it isn't necessarily clear that those tests cover all of the subcomponents of null-aware anti joins, i.e. where the subquery returns a null value, if specific columns of either relation are null, etc. Also, it is somewhat difficult for a newcomer to understand the intended behavior of a null-aware anti join without great effort. We should make sure we have proper coverage as well as improve the documentation of this particular subquery, especially with respect to null behavior.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org