You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/30 08:28:07 UTC

[GitHub] [cloudstack] sureshanaparti commented on pull request #4388: fix NPE in volumes statistics

sureshanaparti commented on pull request #4388:
URL: https://github.com/apache/cloudstack/pull/4388#issuecomment-719408046


   > > code LGTM, haven't tested. Please ensure these changes doesn't cause any regression for managed / unmanaged / local storage.
   > 
   > @sureshanaparti please explain your concerns or ensure what you can? I'm am trusting @slavkap to have validated any configuration she has access too. If you know what to do more please do so or ping the people that can. If we leave it at this I'm pretty sure no follow up will happen.
   
   @DaanHoogland the code changes will impact the volume stats for all storage pools. So, it is better if this can be tested with volume(s) on unmanaged, managed and local storage. Otherwise, can cause regression.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org