You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Rajini Sivaram <ra...@gmail.com> on 2017/08/16 12:34:24 UTC
[DISCUSS] KIP-187 - Add cumulative count metric for all Kafka rate metrics
Hi all,
I have posted a KIP to add a cumulative count attribute for all Kafka rate
metrics to make downstream processing simpler, more accurate and flexible:
Re: [DISCUSS] KIP-187 - Add cumulative count metric for all Kafka
rate metrics
Posted by Rajini Sivaram <ra...@gmail.com>.
Hi all,
If there are no more comments, I will start vote on this KIP tomorrow.
Please let me know if there are any other concerns.
Thanks,
Rajini
On Fri, Aug 18, 2017 at 3:38 AM, Rajini Sivaram <ra...@gmail.com>
wrote:
> Hi Jun,
>
> I have added constructors for all the variations. Haven't included these
> in the KIP since it is an internal class:
>
> https://github.com/apache/kafka/pull/3686/files#diff-
> 00ca7d83906c4fb8a5066e9af9c5c34b
>
> Thank you,
>
> Rajini
>
>
>
> On Fri, Aug 18, 2017 at 1:24 AM, Jun Rao <ju...@confluent.io> wrote:
>
>> Hi, Rajini,
>>
>> Thanks for the KIP. Just a minor comment.
>>
>> Most existing usage of Rate doesn't pass in Count and uses SampledTotal by
>> default. So should we provide an additional constructor like the following
>> that uses SampledTotal?
>>
>> new Meter(rateMetricName, totalMetricName)
>>
>> Thanks,
>>
>> Jun
>>
>> On Thu, Aug 17, 2017 at 3:43 AM, Rajini Sivaram <ra...@gmail.com>
>> wrote:
>>
>> > Thank you, Roger.
>> >
>> > I have changed the naming of the internal classes slightly and updated
>> the
>> > example. The new CompoundStat is called Meter and it combines Rate and
>> > Count (the aggregate), leaving Rate as a simple stat. Will submit an
>> > initial PR to help with the review.
>> >
>> > On Thu, Aug 17, 2017 at 12:09 AM, Roger Hoover <ro...@gmail.com>
>> > wrote:
>> >
>> > > Rajini,
>> > >
>> > > Thank you. This is very useful. Grouping by metric by prefixing the
>> > name
>> > > instead of making them MBeans is not quite as nice but seems like an
>> good
>> > > compromise for backward compatibility.
>> > >
>> > > Cheers,
>> > >
>> > > Roger
>> > >
>> > > On Wed, Aug 16, 2017 at 5:35 AM, Rajini Sivaram <
>> rajinisivaram@gmail.com
>> > >
>> > > wrote:
>> > >
>> > > > Sorry, pressed send by mistake.
>> > > >
>> > > > The KIP is here:
>> > > >
>> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
>> > > > 187+-+Add+cumulative+count+metric+for+all+Kafka+rate+metrics
>> > > >
>> > > > Feedback and suggestions are appreciated.
>> > > >
>> > > > Thank you...
>> > > >
>> > > > Rajini
>> > > >
>> > > >
>> > > > On Wed, Aug 16, 2017 at 1:34 PM, Rajini Sivaram <
>> > rajinisivaram@gmail.com
>> > > >
>> > > > wrote:
>> > > >
>> > > > > Hi all,
>> > > > >
>> > > > > I have posted a KIP to add a cumulative count attribute for all
>> Kafka
>> > > > rate
>> > > > > metrics to make downstream processing simpler, more accurate and
>> > > > flexible:
>> > > > >
>> > > > >
>> > > >
>> > >
>> >
>>
>
>
Re: [DISCUSS] KIP-187 - Add cumulative count metric for all Kafka
rate metrics
Posted by Rajini Sivaram <ra...@gmail.com>.
Hi Jun,
I have added constructors for all the variations. Haven't included these in
the KIP since it is an internal class:
https://github.com/apache/kafka/pull/3686/files#diff-00ca7d83906c4fb8a5066e9af9c5c34b
Thank you,
Rajini
On Fri, Aug 18, 2017 at 1:24 AM, Jun Rao <ju...@confluent.io> wrote:
> Hi, Rajini,
>
> Thanks for the KIP. Just a minor comment.
>
> Most existing usage of Rate doesn't pass in Count and uses SampledTotal by
> default. So should we provide an additional constructor like the following
> that uses SampledTotal?
>
> new Meter(rateMetricName, totalMetricName)
>
> Thanks,
>
> Jun
>
> On Thu, Aug 17, 2017 at 3:43 AM, Rajini Sivaram <ra...@gmail.com>
> wrote:
>
> > Thank you, Roger.
> >
> > I have changed the naming of the internal classes slightly and updated
> the
> > example. The new CompoundStat is called Meter and it combines Rate and
> > Count (the aggregate), leaving Rate as a simple stat. Will submit an
> > initial PR to help with the review.
> >
> > On Thu, Aug 17, 2017 at 12:09 AM, Roger Hoover <ro...@gmail.com>
> > wrote:
> >
> > > Rajini,
> > >
> > > Thank you. This is very useful. Grouping by metric by prefixing the
> > name
> > > instead of making them MBeans is not quite as nice but seems like an
> good
> > > compromise for backward compatibility.
> > >
> > > Cheers,
> > >
> > > Roger
> > >
> > > On Wed, Aug 16, 2017 at 5:35 AM, Rajini Sivaram <
> rajinisivaram@gmail.com
> > >
> > > wrote:
> > >
> > > > Sorry, pressed send by mistake.
> > > >
> > > > The KIP is here:
> > > >
> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > 187+-+Add+cumulative+count+metric+for+all+Kafka+rate+metrics
> > > >
> > > > Feedback and suggestions are appreciated.
> > > >
> > > > Thank you...
> > > >
> > > > Rajini
> > > >
> > > >
> > > > On Wed, Aug 16, 2017 at 1:34 PM, Rajini Sivaram <
> > rajinisivaram@gmail.com
> > > >
> > > > wrote:
> > > >
> > > > > Hi all,
> > > > >
> > > > > I have posted a KIP to add a cumulative count attribute for all
> Kafka
> > > > rate
> > > > > metrics to make downstream processing simpler, more accurate and
> > > > flexible:
> > > > >
> > > > >
> > > >
> > >
> >
>
Re: [DISCUSS] KIP-187 - Add cumulative count metric for all Kafka
rate metrics
Posted by Jun Rao <ju...@confluent.io>.
Hi, Rajini,
Thanks for the KIP. Just a minor comment.
Most existing usage of Rate doesn't pass in Count and uses SampledTotal by
default. So should we provide an additional constructor like the following
that uses SampledTotal?
new Meter(rateMetricName, totalMetricName)
Thanks,
Jun
On Thu, Aug 17, 2017 at 3:43 AM, Rajini Sivaram <ra...@gmail.com>
wrote:
> Thank you, Roger.
>
> I have changed the naming of the internal classes slightly and updated the
> example. The new CompoundStat is called Meter and it combines Rate and
> Count (the aggregate), leaving Rate as a simple stat. Will submit an
> initial PR to help with the review.
>
> On Thu, Aug 17, 2017 at 12:09 AM, Roger Hoover <ro...@gmail.com>
> wrote:
>
> > Rajini,
> >
> > Thank you. This is very useful. Grouping by metric by prefixing the
> name
> > instead of making them MBeans is not quite as nice but seems like an good
> > compromise for backward compatibility.
> >
> > Cheers,
> >
> > Roger
> >
> > On Wed, Aug 16, 2017 at 5:35 AM, Rajini Sivaram <rajinisivaram@gmail.com
> >
> > wrote:
> >
> > > Sorry, pressed send by mistake.
> > >
> > > The KIP is here:
> > >
> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > 187+-+Add+cumulative+count+metric+for+all+Kafka+rate+metrics
> > >
> > > Feedback and suggestions are appreciated.
> > >
> > > Thank you...
> > >
> > > Rajini
> > >
> > >
> > > On Wed, Aug 16, 2017 at 1:34 PM, Rajini Sivaram <
> rajinisivaram@gmail.com
> > >
> > > wrote:
> > >
> > > > Hi all,
> > > >
> > > > I have posted a KIP to add a cumulative count attribute for all Kafka
> > > rate
> > > > metrics to make downstream processing simpler, more accurate and
> > > flexible:
> > > >
> > > >
> > >
> >
>
Re: [DISCUSS] KIP-187 - Add cumulative count metric for all Kafka
rate metrics
Posted by Rajini Sivaram <ra...@gmail.com>.
Thank you, Roger.
I have changed the naming of the internal classes slightly and updated the
example. The new CompoundStat is called Meter and it combines Rate and
Count (the aggregate), leaving Rate as a simple stat. Will submit an
initial PR to help with the review.
On Thu, Aug 17, 2017 at 12:09 AM, Roger Hoover <ro...@gmail.com>
wrote:
> Rajini,
>
> Thank you. This is very useful. Grouping by metric by prefixing the name
> instead of making them MBeans is not quite as nice but seems like an good
> compromise for backward compatibility.
>
> Cheers,
>
> Roger
>
> On Wed, Aug 16, 2017 at 5:35 AM, Rajini Sivaram <ra...@gmail.com>
> wrote:
>
> > Sorry, pressed send by mistake.
> >
> > The KIP is here:
> >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > 187+-+Add+cumulative+count+metric+for+all+Kafka+rate+metrics
> >
> > Feedback and suggestions are appreciated.
> >
> > Thank you...
> >
> > Rajini
> >
> >
> > On Wed, Aug 16, 2017 at 1:34 PM, Rajini Sivaram <rajinisivaram@gmail.com
> >
> > wrote:
> >
> > > Hi all,
> > >
> > > I have posted a KIP to add a cumulative count attribute for all Kafka
> > rate
> > > metrics to make downstream processing simpler, more accurate and
> > flexible:
> > >
> > >
> >
>
Re: [DISCUSS] KIP-187 - Add cumulative count metric for all Kafka
rate metrics
Posted by Roger Hoover <ro...@gmail.com>.
Rajini,
Thank you. This is very useful. Grouping by metric by prefixing the name
instead of making them MBeans is not quite as nice but seems like an good
compromise for backward compatibility.
Cheers,
Roger
On Wed, Aug 16, 2017 at 5:35 AM, Rajini Sivaram <ra...@gmail.com>
wrote:
> Sorry, pressed send by mistake.
>
> The KIP is here:
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 187+-+Add+cumulative+count+metric+for+all+Kafka+rate+metrics
>
> Feedback and suggestions are appreciated.
>
> Thank you...
>
> Rajini
>
>
> On Wed, Aug 16, 2017 at 1:34 PM, Rajini Sivaram <ra...@gmail.com>
> wrote:
>
> > Hi all,
> >
> > I have posted a KIP to add a cumulative count attribute for all Kafka
> rate
> > metrics to make downstream processing simpler, more accurate and
> flexible:
> >
> >
>
Re: [DISCUSS] KIP-187 - Add cumulative count metric for all Kafka
rate metrics
Posted by Rajini Sivaram <ra...@gmail.com>.
Sorry, pressed send by mistake.
The KIP is here:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-187+-+Add+cumulative+count+metric+for+all+Kafka+rate+metrics
Feedback and suggestions are appreciated.
Thank you...
Rajini
On Wed, Aug 16, 2017 at 1:34 PM, Rajini Sivaram <ra...@gmail.com>
wrote:
> Hi all,
>
> I have posted a KIP to add a cumulative count attribute for all Kafka rate
> metrics to make downstream processing simpler, more accurate and flexible:
>
>