[GitHub] [superset] justinpark commented on pull request #25282: fix(nativeFilters): Speed up native filters by removing unnecessary rerenders

["justinpark (via GitHub)" <gi...@apache.org>]

justinpark commented on PR #25282:
URL: https://github.com/apache/superset/pull/25282#issuecomment-1736310335

   @Always-prog 
   Please add the following fix on useFilterDependencies which misses `shallowEqual` on useSelector
   
   https://github.com/apache/superset/blob/0c083bdc1af4e6a3e17155246a3134cb5cb5887d/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/state.ts#L33-L35
   
   ```
   import { shallowEqual, useSelector } from 'react-redux';
   ...
     const dependencyIds = useSelector<any, string[] | undefined>(
       state => state.nativeFilters.filters[id]?.cascadeParentIds,
       shallowEqual,
     );
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org