[GitHub] [ozone] ChenSammi commented on a diff in pull request #3144: HDDS-6383. SCM Web UI doesn’t show correct leader/follower HA info

[GitBox <gi...@apache.org>]

ChenSammi commented on code in PR #3144:
URL: https://github.com/apache/ozone/pull/3144#discussion_r846964152


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/HddsUtils.java:
##########
@@ -614,8 +614,7 @@ public static String format(List<String> nodes) {
     for (String node : nodes) {
       String[] x = node.split(":");
       sb.append(String
-          .format("{ HostName : %s, Ratis Port : %s, Role : %s } ", x[0], x[1],
-              x[2]));
+          .format("{ HostName : %s, Ratis Port : %s } ", x[0], x[1]));

Review Comment:
   Thanks @sadanand48 for reporting this issue. 
   
   This string format is not only used on Web UI, but also the CLI scm roles command.  So I would suggest keep the Role info here. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org