You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/31 06:06:52 UTC

[GitHub] [flink] fsk119 commented on a diff in pull request #19847: [FLINK-27683][table-planner] Fix SQL hints can't work with targetColumns

fsk119 commented on code in PR #19847:
URL: https://github.com/apache/flink/pull/19847#discussion_r885232420


##########
flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSinkITCase.java:
##########
@@ -311,6 +311,48 @@ public void testAppend() throws Exception {
                 new String[] {"id", "num", "ts"});
     }
 
+    @Test
+    public void testSqlHintWithTargetColumns() throws Exception {

Review Comment:
   I think we can refer to the #18967 and plan/IT tests. The modification is mainly about the planner and we don't need to add tests in the connector package.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org