You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yao Xu (Code Review)" <ge...@cloudera.org> on 2019/05/27 08:14:27 UTC
[kudu-CR] [client] C++ tableExists API optimizations
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13443
Change subject: [client] C++ tableExists API optimizations
......................................................................
[client] C++ tableExists API optimizations
The C++ client `tableExists` should use GetTableSchema.
See KUDU-2802 for details.
Change-Id: Ie3a7c325adf464d0932d84001de6753079f64ee6
---
M src/kudu/client/client.cc
1 file changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/13443/1
--
To view, visit http://gerrit.cloudera.org:8080/13443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3a7c325adf464d0932d84001de6753079f64ee6
Gerrit-Change-Number: 13443
Gerrit-PatchSet: 1
Gerrit-Owner: Yao Xu <oc...@gmail.com>
[kudu-CR] KUDU-2802: C++ tableExists API optimizations
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13443 )
Change subject: KUDU-2802: C++ tableExists API optimizations
......................................................................
KUDU-2802: C++ tableExists API optimizations
Change-Id: Ie3a7c325adf464d0932d84001de6753079f64ee6
Reviewed-on: http://gerrit.cloudera.org:8080/13443
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/client/client.cc
1 file changed, 7 insertions(+), 9 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3a7c325adf464d0932d84001de6753079f64ee6
Gerrit-Change-Number: 13443
Gerrit-PatchSet: 4
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [client] C++ tableExists API optimizations
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13443 )
Change subject: [client] C++ tableExists API optimizations
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13443/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13443/1//COMMIT_MSG@6
PS1, Line 6:
: [client] C++ tableExists API optimizations
:
: The C++ client `tableExists` should use GetTableSchema.
: See KUDU-2802 for details.
Nit: you can just say:
KUDU-2802: C++ tableExists API optimizations
I think that's enough content to explain what's going on here.
--
To view, visit http://gerrit.cloudera.org:8080/13443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3a7c325adf464d0932d84001de6753079f64ee6
Gerrit-Change-Number: 13443
Gerrit-PatchSet: 1
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 28 May 2019 03:27:32 +0000
Gerrit-HasComments: Yes
[kudu-CR] [client] C++ tableExists API optimizations
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13443 )
Change subject: [client] C++ tableExists API optimizations
......................................................................
Patch Set 1:
(1 comment)
Thank you for your contribution!
http://gerrit.cloudera.org:8080/#/c/13443/1/src/kudu/client/client.cc
File src/kudu/client/client.cc:
http://gerrit.cloudera.org:8080/#/c/13443/1/src/kudu/client/client.cc@495
PS1, Line 495: OpenTable
KuduClient::OpenTable() does more than enough in this context of poking into the space of existing tables. I think using KuduClient::GetTableSchema() is a better choice here:
auto s = GetTableSchema(table_name, nullptr);
...
Also, please address the warning from TidyBot.
--
To view, visit http://gerrit.cloudera.org:8080/13443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3a7c325adf464d0932d84001de6753079f64ee6
Gerrit-Change-Number: 13443
Gerrit-PatchSet: 1
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 27 May 2019 19:34:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2802: C++ tableExists API optimizations
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13443 )
Change subject: KUDU-2802: C++ tableExists API optimizations
......................................................................
Patch Set 3: Verified+1 Code-Review+2
Overriding Jenkins, the test failure was a known flake and unrelated.
--
To view, visit http://gerrit.cloudera.org:8080/13443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3a7c325adf464d0932d84001de6753079f64ee6
Gerrit-Change-Number: 13443
Gerrit-PatchSet: 3
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 28 May 2019 04:51:39 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2802: C++ tableExists API optimizations
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13443 )
Change subject: KUDU-2802: C++ tableExists API optimizations
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ie3a7c325adf464d0932d84001de6753079f64ee6
Gerrit-Change-Number: 13443
Gerrit-PatchSet: 3
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [client] C++ tableExists API optimizations
Posted by "Yao Xu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13443
to look at the new patch set (#2).
Change subject: [client] C++ tableExists API optimizations
......................................................................
[client] C++ tableExists API optimizations
The C++ client `tableExists` should use GetTableSchema.
See KUDU-2802 for details.
Change-Id: Ie3a7c325adf464d0932d84001de6753079f64ee6
---
M src/kudu/client/client.cc
1 file changed, 7 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/13443/2
--
To view, visit http://gerrit.cloudera.org:8080/13443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie3a7c325adf464d0932d84001de6753079f64ee6
Gerrit-Change-Number: 13443
Gerrit-PatchSet: 2
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-2802: C++ tableExists API optimizations
Posted by "Yao Xu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13443
to look at the new patch set (#3).
Change subject: KUDU-2802: C++ tableExists API optimizations
......................................................................
KUDU-2802: C++ tableExists API optimizations
Change-Id: Ie3a7c325adf464d0932d84001de6753079f64ee6
---
M src/kudu/client/client.cc
1 file changed, 7 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/13443/3
--
To view, visit http://gerrit.cloudera.org:8080/13443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie3a7c325adf464d0932d84001de6753079f64ee6
Gerrit-Change-Number: 13443
Gerrit-PatchSet: 3
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)