You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/08/09 18:56:15 UTC

[GitHub] [kafka] wcarlson5 commented on a change in pull request #11192: KAFKA-12779: rename namedTopology in TaskId to topologyName

wcarlson5 commented on a change in pull request #11192:
URL: https://github.com/apache/kafka/pull/11192#discussion_r685443125



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/TaskId.java
##########
@@ -76,13 +76,13 @@ public int partition() {
     /**
      * Experimental feature -- will return null
      */
-    public String namedTopology() {
-        return namedTopology;
+    public String topologyName() {
+        return topologyName;

Review comment:
       It's by convention I think. If you look at all of the other "getters" none of them are prefixed with get either. I.e. partition() or subtopology()




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org