You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by gorkem <gi...@git.apache.org> on 2014/10/27 20:48:00 UTC
[GitHub] cordova-lib pull request: CB-6472 Merge dictionaries when updating...
GitHub user gorkem opened a pull request:
https://github.com/apache/cordova-lib/pull/115
CB-6472 Merge dictionaries when updating plist files
Merges the dictionaries on plist files if both plist and the value from plugin.xml are dictionaries. This makes it consistent with how it behaves with array values.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gorkem/cordova-lib CB-6472
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/115.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #115
----
commit 6bb5592d76ea3fc426ff87c0f7091dd9d985df1c
Author: Gorkem Ercan <go...@gmail.com>
Date: 2014-10-27T17:35:09Z
[CB-6472] Adding content to -Info.plist - Unexpected behaviour
Merge instead of replace when the destination and source nodes
are both of type dictionary. Adds underscore.js as a dependency
commit 87173e00ee3242bf070343fe22b1644c10b1a994
Author: Gorkem Ercan <go...@gmail.com>
Date: 2014-10-27T19:42:06Z
Tests for merging dictionaries
Tests plist, if dictionary keys are actually merged when it already exists.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-6472 Merge dictionaries when updating...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/115
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-6472 Merge dictionaries when updating...
Posted by kamrik <gi...@git.apache.org>.
Github user kamrik commented on the pull request:
https://github.com/apache/cordova-lib/pull/115#issuecomment-63848626
Looks good overall. 2 style notes, both are optional, tell me if you prefer not to change it:
1) Would be great if you could run jscs with the default config in cordova-lib/.jscs.json, it's not set in stone and you are welcome to contribute to the discussion of what this configuration should look like. But it really helps with obvious things like trailing spaces etc. that jshint stopped checking for in the latest versions.
2) underscore usage as "_" turns out to be a bit problematic in node.js during debugging because node interactive interpreter uses _ to keep the last printed result. There seem to be no other dominant conventions, but double underscore "__" is a popular choice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-6472 Merge dictionaries when updating...
Posted by kamrik <gi...@git.apache.org>.
Github user kamrik commented on the pull request:
https://github.com/apache/cordova-lib/pull/115#issuecomment-64065820
Cool, thanks. Merged.
For the linters, looks like the authors of JSCS and jshint work together and actually recommend using them both in combination. https://github.com/jshint/jshint/issues/1358
We do have a jscs config file in this project, but some work is still needed before we can start enforcing it as part of npm test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-6472 Merge dictionaries when updating...
Posted by gorkem <gi...@git.apache.org>.
Github user gorkem commented on the pull request:
https://github.com/apache/cordova-lib/pull/115#issuecomment-64043986
made some style changes and renamed underscore..
Perhaps we should move to use eslint instead of jshint, I think that still has the style checks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org