[GitHub] [geode] jmelchio opened pull request #4386: GEODE-7504: region eviction support

["jmelchio (GitHub)" <gi...@apache.org>]

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/4386 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jmelchio commented on issue #4386: GEODE-7504: region eviction support

["jmelchio (GitHub)" <gi...@apache.org>]

@jinmeiliao @dschneider-pivotal @demery-pivotal 

[ Full content available at: https://github.com/apache/geode/pull/4386 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on pull request #4386: GEODE-7504: region eviction support

["jinmeiliao (GitHub)" <gi...@apache.org>]

I thought setEntryCount would also set the type implicitly.

[ Full content available at: https://github.com/apache/geode/pull/4386 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on pull request #4386: GEODE-7504: region eviction support

["jinmeiliao (GitHub)" <gi...@apache.org>]

I think the differences is the later approach would give user less opportunities to create an invalid object to begin with, whereas the the previous approach will let user create any combination of attributes and let validator to catch all the invalid cases.

[ Full content available at: https://github.com/apache/geode/pull/4386 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #4386: GEODE-7504: region eviction support

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

add javadocs describing when it will throw
also describe that it will also set the type to...l

[ Full content available at: https://github.com/apache/geode/pull/4386 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jmelchio commented on pull request #4386: GEODE-7504: region eviction support

["jmelchio (GitHub)" <gi...@apache.org>]

It does get set in the cluster configuration after conversion.

[ Full content available at: https://github.com/apache/geode/pull/4386 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jmelchio commented on pull request #4386: GEODE-7504: region eviction support

["jmelchio (GitHub)" <gi...@apache.org>]

Yes, upon conversion we assume that given that we have an entryCount value that the type is `ENTRY_COUNT` and we save it as such in the cluster configuration.

[ Full content available at: https://github.com/apache/geode/pull/4386 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org