You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Cody Maloney <co...@mesosphere.io> on 2015/08/05 05:30:36 UTC
Re: Review Request 36810: Don't check protobuf jar in libprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36810/#review94175
-----------------------------------------------------------
Ship it!
Seems reasonable to me. I haven't run a build personally toto guarantee things keep working.
- Cody Maloney
On Aug. 4, 2015, 9:27 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36810/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 9:27 a.m.)
>
>
> Review request for mesos, Adam B, Cody Maloney, Michael Park, and Timothy St. Clair.
>
>
> Bugs: MESOS-2480
> https://issues.apache.org/jira/browse/MESOS-2480
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Don't check protobuf jar in libprocess.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac 7d1221bd5ddfc4fa816b0bbea0be5c6b20000cbb
>
> Diff: https://reviews.apache.org/r/36810/diff/
>
>
> Testing
> -------
>
> ../configure --with-protobuf=/usr/local --disable-java
> make -j4
> make check -j4 GTEST_FILTER=-"*"
>
>
> Thanks,
>
> haosdent huang
>
>