You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "csanchezdll (via GitHub)" <gi...@apache.org> on 2026/03/17 10:03:56 UTC
[PR] arch/arm/src/stm32h5: add support for HW RNG. [nuttx]
csanchezdll opened a new pull request, #18549:
URL: https://github.com/apache/nuttx/pull/18549
Driver copied from stm32f7, which includes CEIS/SEIS clearing per reference manual.
## Summary
STM32H5 MCUs have a random number generation. According to the datasheets, the whole family has it, so there is no need
to make the change conditional on specific part number as other families (STM32H7, for example, do).
There are two slightly different implementations of the RNG driver. One is used in plain stm32, stm32h7,and stm32f0l0g0: when error flags SEIS/CEIS are set it just reads DR again. The other is used in stm32f7 and stm32l4: it clears those flags and disables/re-enables RNG on failure. This second one is the correct procedure according to the manual, so I have made stm32h5 one used that one (copies from stm32f7).
## Impact
This change will affect all STM32H5 platforms, making /dev/random appear and /dev/urandom support available for selection using Kconfig.
## Testing
TBD
*This section should provide a detailed description of what you did
to verify your changes work and do not break existing code.*
*Please provide information about your host machine, the board(s) you
tested your changes on, and how you tested. Logs should be included.*
*For example, when changing something in the core OS functions, you
may want to run the OSTest application to verify that there are no
regressions. Changes to ADC code may warrant running the `adc`
example. Adding a new uORB driver may require that you run
`uorb_listener` to verify correct operation.*
*Pure documentation changes can just be tested with `make html`
(see docs) and verification of the correct format in your
browser.*
**_PRs without testing information will not be accepted. We will
request test logs._**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm/src/stm32h5: add support for HW RNG. [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #18549:
URL: https://github.com/apache/nuttx/pull/18549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm/src/stm32h5: add support for HW RNG. [nuttx]
Posted by "simbit18 (via GitHub)" <gi...@apache.org>.
simbit18 commented on PR #18549:
URL: https://github.com/apache/nuttx/pull/18549#issuecomment-4088807432
@csanchezdll Don't worry. You just have to wait three hours now and be a little more patient!!! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm/src/stm32h5: add support for HW RNG. [nuttx]
Posted by "simbit18 (via GitHub)" <gi...@apache.org>.
simbit18 commented on PR #18549:
URL: https://github.com/apache/nuttx/pull/18549#issuecomment-4073851514
Hi @csanchezdll, please align CMake with Make
add stm32_rng.c
https://github.com/csanchezdll/incubator-nuttx/blob/7742cff29e3ceff166aeedb1e00c6310177a37b8/arch/arm/src/stm32h5/CMakeLists.txt#L40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm/src/stm32h5: add support for HW RNG. [nuttx]
Posted by "simbit18 (via GitHub)" <gi...@apache.org>.
simbit18 commented on PR #18549:
URL: https://github.com/apache/nuttx/pull/18549#issuecomment-4083456138
Hi @csanchezdll, please fix
```
../nuttx/tools/checkpatch.sh -c -u -m -g b9c639f604b5247a7527fc4143b88cd9d905a332..HEAD
Used config files:
1: .codespellrc
Error: /home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/stm32h5/stm32h5xx_rcc.c:1205:1: error: Blank line contains whitespace
Error: /home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/stm32h5/stm32h5xx_rcc.c:1214:1: error: Blank line contains whitespace
Some checks failed. For contributing guidelines, see:
https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md
Error: Process completed with exit code 1.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm/src/stm32h5: add support for HW RNG. [nuttx]
Posted by "csanchezdll (via GitHub)" <gi...@apache.org>.
csanchezdll commented on PR #18549:
URL: https://github.com/apache/nuttx/pull/18549#issuecomment-4088604111
It seems the checks failed for external reasons:
```
2026-03-18T17:08:37.0961786Z ====================================================================================
2026-03-18T17:08:37.0985532Z Cmake in present: nrf52832-dk/sdc_nimble,CONFIG_ARM_TOOLCHAIN_GNU_EABI
2026-03-18T17:08:37.0986163Z Configuration/Tool: nrf52832-dk/sdc_nimble,CONFIG_ARM_TOOLCHAIN_GNU_EABI
2026-03-18T17:08:37.1082281Z 2026-03-18 17:08:37
2026-03-18T17:08:37.1082912Z ------------------------------------------------------------------------------------
2026-03-18T17:08:37.1083565Z Cleaning...
2026-03-18T17:08:37.1083912Z Configuring...
2026-03-18T17:08:40.6514312Z Select HOST_LINUX=y
2026-03-18T17:08:42.4686084Z TOOLS_DIR path is "/github/workspace/sources/nuttx"
2026-03-18T17:08:42.4686690Z HOST = Linux
2026-03-18T17:09:12.8302758Z CMake Error at /github/workspace/sources/nuttx/build/_deps/sdk-nrfxlib-subbuild/sdk-nrfxlib-populate-prefix/src/sdk-nrfxlib-populate-stamp/download-sdk-nrfxlib-populate.cmake:170 (message):
2026-03-18T17:09:12.8305413Z Each download failed!
2026-03-18T17:09:12.8305662Z
2026-03-18T17:09:12.8306251Z error: downloading 'https://github.com/nrfconnect/sdk-nrfxlib/archive/v2.3.0.tar.gz' failed
2026-03-18T17:09:12.8307418Z status_code: 28
2026-03-18T17:09:12.8307887Z status_string: "Timeout was reached"
```
I have checked other runs of the same build job Linux (arm-05) on other PRs and it runs well, so I guess this is a transient error.
I am re-pushing to force a re-run (maybe admins can trigger a run on this job only, but I can not).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm/src/stm32h5: add support for HW RNG. [nuttx]
Posted by "csanchezdll (via GitHub)" <gi...@apache.org>.
csanchezdll commented on PR #18549:
URL: https://github.com/apache/nuttx/pull/18549#issuecomment-4088794909
Sorry @simbit18 I read it just after re-pushing. No way I can stop it now. I will be more patient next time, knowing that can be done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm/src/stm32h5: add support for HW RNG. [nuttx]
Posted by "simbit18 (via GitHub)" <gi...@apache.org>.
simbit18 commented on PR #18549:
URL: https://github.com/apache/nuttx/pull/18549#issuecomment-4088789011
Hi @csanchezdll, I restarted the failed jobs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org