You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Antonio Petrelli (JIRA)" <de...@velocity.apache.org> on 2010/12/01 13:20:11 UTC
[jira] Created: (VELOCITY-790) Improve configuration facility
Improve configuration facility
------------------------------
Key: VELOCITY-790
URL: https://issues.apache.org/jira/browse/VELOCITY-790
Project: Velocity
Issue Type: Bug
Components: Engine
Reporter: Antonio Petrelli
Assignee: Antonio Petrelli
Currently the whole configuration of Velocity Engine is managed by ExtendedProperties, a class from Commons Collections.
An interface that abstracts from this implementation, and an implementation that uses normal Properties should be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-790) Improve configuration facility
Posted by "Nathan Bubna (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970314#action_12970314 ]
Nathan Bubna commented on VELOCITY-790:
---------------------------------------
Yeah, no null booleans in config, please. And the only type conversion in Velocity internals is toString(), i believe.
> Improve configuration facility
> ------------------------------
>
> Key: VELOCITY-790
> URL: https://issues.apache.org/jira/browse/VELOCITY-790
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 2.0
> Reporter: Antonio Petrelli
> Assignee: Adrian Tarau
> Fix For: 2.0
>
>
> Currently the whole configuration of Velocity Engine is managed by ExtendedProperties, a class from Commons Collections.
> An interface that abstracts from this implementation, and an implementation that uses normal Properties should be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-790) Improve configuration facility
Posted by "Adrian Tarau (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968554#action_12968554 ]
Adrian Tarau commented on VELOCITY-790:
---------------------------------------
I'm thinking to add a dependency to BeanUtils's converters package(this dependency will not be propagated within Maven, it will be used just to build Velocity and at runtime the converters packages will be part of Velocity under org.apache.velocity.converters using shading) for type conversion in Configuration. This will add 47kb in compressed byte code but I think it's worth it...if not approved I will go with a simpler type conversion(only from String to type XXX).
http://commons.apache.org/beanutils/v1.8.3/apidocs/index.html?org/apache/commons/beanutils/converters/package-summary.html
> Improve configuration facility
> ------------------------------
>
> Key: VELOCITY-790
> URL: https://issues.apache.org/jira/browse/VELOCITY-790
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 2.0
> Reporter: Antonio Petrelli
> Assignee: Adrian Tarau
> Fix For: 2.0
>
>
> Currently the whole configuration of Velocity Engine is managed by ExtendedProperties, a class from Commons Collections.
> An interface that abstracts from this implementation, and an implementation that uses normal Properties should be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-790) Improve configuration facility
Posted by "Adrian Tarau (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965689#action_12965689 ]
Adrian Tarau commented on VELOCITY-790:
---------------------------------------
Can I take this one?
> Improve configuration facility
> ------------------------------
>
> Key: VELOCITY-790
> URL: https://issues.apache.org/jira/browse/VELOCITY-790
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Reporter: Antonio Petrelli
> Assignee: Antonio Petrelli
>
> Currently the whole configuration of Velocity Engine is managed by ExtendedProperties, a class from Commons Collections.
> An interface that abstracts from this implementation, and an implementation that uses normal Properties should be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-790) Improve configuration facility
Posted by "Adrian Tarau (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968551#action_12968551 ]
Adrian Tarau commented on VELOCITY-790:
---------------------------------------
I will drop them
> Improve configuration facility
> ------------------------------
>
> Key: VELOCITY-790
> URL: https://issues.apache.org/jira/browse/VELOCITY-790
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 2.0
> Reporter: Antonio Petrelli
> Assignee: Adrian Tarau
> Fix For: 2.0
>
>
> Currently the whole configuration of Velocity Engine is managed by ExtendedProperties, a class from Commons Collections.
> An interface that abstracts from this implementation, and an implementation that uses normal Properties should be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Updated: (VELOCITY-790) Improve configuration facility
Posted by "Antonio Petrelli (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli updated VELOCITY-790:
--------------------------------------
Affects Version/s: 2.0
Fix Version/s: 2.0
> Improve configuration facility
> ------------------------------
>
> Key: VELOCITY-790
> URL: https://issues.apache.org/jira/browse/VELOCITY-790
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 2.0
> Reporter: Antonio Petrelli
> Assignee: Antonio Petrelli
> Fix For: 2.0
>
>
> Currently the whole configuration of Velocity Engine is managed by ExtendedProperties, a class from Commons Collections.
> An interface that abstracts from this implementation, and an implementation that uses normal Properties should be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-790) Improve configuration facility
Posted by "Antonio Petrelli (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965693#action_12965693 ]
Antonio Petrelli commented on VELOCITY-790:
-------------------------------------------
Since I didn't start yet, it's all yours :-D
Thanks
> Improve configuration facility
> ------------------------------
>
> Key: VELOCITY-790
> URL: https://issues.apache.org/jira/browse/VELOCITY-790
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 2.0
> Reporter: Antonio Petrelli
> Assignee: Antonio Petrelli
> Fix For: 2.0
>
>
> Currently the whole configuration of Velocity Engine is managed by ExtendedProperties, a class from Commons Collections.
> An interface that abstracts from this implementation, and an implementation that uses normal Properties should be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-790) Improve configuration facility
Posted by "Nathan Bubna (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966984#action_12966984 ]
Nathan Bubna commented on VELOCITY-790:
---------------------------------------
I prefer org.apache.velocity.configuration.
I have to constantly fight the urge to abolish both the o.a.v.app and o.a.v.runtime packages. Too many of the packages under o.a.v. are unnecessary, IMO.
> Improve configuration facility
> ------------------------------
>
> Key: VELOCITY-790
> URL: https://issues.apache.org/jira/browse/VELOCITY-790
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 2.0
> Reporter: Antonio Petrelli
> Assignee: Adrian Tarau
> Fix For: 2.0
>
>
> Currently the whole configuration of Velocity Engine is managed by ExtendedProperties, a class from Commons Collections.
> An interface that abstracts from this implementation, and an implementation that uses normal Properties should be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-790) Improve configuration facility
Posted by "Adrian Tarau (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969620#action_12969620 ]
Adrian Tarau commented on VELOCITY-790:
---------------------------------------
Also does it make sense for Velocity "Boolean getBoolean(String key, Boolean defaultValue)" to allow a null value for a configuration key?
I would say "boolean getBoolean(String key, boolean defaultValue)" should be enough...a "primitive" type should not be allowed to have a null value, default/safe value should be provided all the time.
> Improve configuration facility
> ------------------------------
>
> Key: VELOCITY-790
> URL: https://issues.apache.org/jira/browse/VELOCITY-790
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 2.0
> Reporter: Antonio Petrelli
> Assignee: Adrian Tarau
> Fix For: 2.0
>
>
> Currently the whole configuration of Velocity Engine is managed by ExtendedProperties, a class from Commons Collections.
> An interface that abstracts from this implementation, and an implementation that uses normal Properties should be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-790) Improve configuration facility
Posted by "Adrian Tarau (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966983#action_12966983 ]
Adrian Tarau commented on VELOCITY-790:
---------------------------------------
Any suggestions for the configuration package?
1. org.apache.velocity.configuration
2. org.apache.velocity.app.configuration
3. org.apache.velocity.runtime.configuration
I would say org.apache.velocity.runtime.configuration ...
> Improve configuration facility
> ------------------------------
>
> Key: VELOCITY-790
> URL: https://issues.apache.org/jira/browse/VELOCITY-790
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 2.0
> Reporter: Antonio Petrelli
> Assignee: Adrian Tarau
> Fix For: 2.0
>
>
> Currently the whole configuration of Velocity Engine is managed by ExtendedProperties, a class from Commons Collections.
> An interface that abstracts from this implementation, and an implementation that uses normal Properties should be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-790) Improve configuration facility
Posted by "Adrian Tarau (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966989#action_12966989 ]
Adrian Tarau commented on VELOCITY-790:
---------------------------------------
Well, 2.0 might be the version where a little bit of refactoring would not hurt :)
> Improve configuration facility
> ------------------------------
>
> Key: VELOCITY-790
> URL: https://issues.apache.org/jira/browse/VELOCITY-790
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 2.0
> Reporter: Antonio Petrelli
> Assignee: Adrian Tarau
> Fix For: 2.0
>
>
> Currently the whole configuration of Velocity Engine is managed by ExtendedProperties, a class from Commons Collections.
> An interface that abstracts from this implementation, and an implementation that uses normal Properties should be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Assigned: (VELOCITY-790) Improve configuration facility
Posted by "Adrian Tarau (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Tarau reassigned VELOCITY-790:
-------------------------------------
Assignee: Adrian Tarau
> Improve configuration facility
> ------------------------------
>
> Key: VELOCITY-790
> URL: https://issues.apache.org/jira/browse/VELOCITY-790
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 2.0
> Reporter: Antonio Petrelli
> Assignee: Adrian Tarau
> Fix For: 2.0
>
>
> Currently the whole configuration of Velocity Engine is managed by ExtendedProperties, a class from Commons Collections.
> An interface that abstracts from this implementation, and an implementation that uses normal Properties should be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-790) Improve configuration facility
Posted by "Nathan Bubna (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12967098#action_12967098 ]
Nathan Bubna commented on VELOCITY-790:
---------------------------------------
No need for them with regard to configuration.
> Improve configuration facility
> ------------------------------
>
> Key: VELOCITY-790
> URL: https://issues.apache.org/jira/browse/VELOCITY-790
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 2.0
> Reporter: Antonio Petrelli
> Assignee: Adrian Tarau
> Fix For: 2.0
>
>
> Currently the whole configuration of Velocity Engine is managed by ExtendedProperties, a class from Commons Collections.
> An interface that abstracts from this implementation, and an implementation that uses normal Properties should be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-790) Improve configuration facility
Posted by "Adrian Tarau (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12967074#action_12967074 ]
Adrian Tarau commented on VELOCITY-790:
---------------------------------------
Usually it is worth it...Code gets "dirty" and a clean-up is at least recommended if not required :).
> Improve configuration facility
> ------------------------------
>
> Key: VELOCITY-790
> URL: https://issues.apache.org/jira/browse/VELOCITY-790
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 2.0
> Reporter: Antonio Petrelli
> Assignee: Adrian Tarau
> Fix For: 2.0
>
>
> Currently the whole configuration of Velocity Engine is managed by ExtendedProperties, a class from Commons Collections.
> An interface that abstracts from this implementation, and an implementation that uses normal Properties should be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-790) Improve configuration facility
Posted by "Adrian Tarau (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969619#action_12969619 ]
Adrian Tarau commented on VELOCITY-790:
---------------------------------------
Only the configuration...for now. I was trying to find where Velocity do some type conversion and I didn't saw anything to suggest that(didn't looked to much either). I would expect when invoking $obj.setThing($thing) with setThing(int) and type($thing) = String to have an automatic type conversion(if possible otherwise exception). Is either I was type safe all the time or either there is a type conversion somewhere :)
> Improve configuration facility
> ------------------------------
>
> Key: VELOCITY-790
> URL: https://issues.apache.org/jira/browse/VELOCITY-790
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 2.0
> Reporter: Antonio Petrelli
> Assignee: Adrian Tarau
> Fix For: 2.0
>
>
> Currently the whole configuration of Velocity Engine is managed by ExtendedProperties, a class from Commons Collections.
> An interface that abstracts from this implementation, and an implementation that uses normal Properties should be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-790) Improve configuration facility
Posted by "Adrian Tarau (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12967093#action_12967093 ]
Adrian Tarau commented on VELOCITY-790:
---------------------------------------
Any need for BigDecimal and BigInteger in Velocity?
> Improve configuration facility
> ------------------------------
>
> Key: VELOCITY-790
> URL: https://issues.apache.org/jira/browse/VELOCITY-790
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 2.0
> Reporter: Antonio Petrelli
> Assignee: Adrian Tarau
> Fix For: 2.0
>
>
> Currently the whole configuration of Velocity Engine is managed by ExtendedProperties, a class from Commons Collections.
> An interface that abstracts from this implementation, and an implementation that uses normal Properties should be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Assigned: (VELOCITY-790) Improve configuration facility
Posted by "Antonio Petrelli (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli reassigned VELOCITY-790:
-----------------------------------------
Assignee: (was: Antonio Petrelli)
> Improve configuration facility
> ------------------------------
>
> Key: VELOCITY-790
> URL: https://issues.apache.org/jira/browse/VELOCITY-790
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 2.0
> Reporter: Antonio Petrelli
> Fix For: 2.0
>
>
> Currently the whole configuration of Velocity Engine is managed by ExtendedProperties, a class from Commons Collections.
> An interface that abstracts from this implementation, and an implementation that uses normal Properties should be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-790) Improve configuration facility
Posted by "Nathan Bubna (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966990#action_12966990 ]
Nathan Bubna commented on VELOCITY-790:
---------------------------------------
Yeah, but is it worth it at this point?
> Improve configuration facility
> ------------------------------
>
> Key: VELOCITY-790
> URL: https://issues.apache.org/jira/browse/VELOCITY-790
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 2.0
> Reporter: Antonio Petrelli
> Assignee: Adrian Tarau
> Fix For: 2.0
>
>
> Currently the whole configuration of Velocity Engine is managed by ExtendedProperties, a class from Commons Collections.
> An interface that abstracts from this implementation, and an implementation that uses normal Properties should be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-790) Improve configuration facility
Posted by "Adrian Tarau (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12967090#action_12967090 ]
Adrian Tarau commented on VELOCITY-790:
---------------------------------------
During the implementation I started with a few suppositions:
- used Apache Commons Configuration(http://commons.apache.org/configuration/apidocs/index.html), it seems like a good model to me(I use it in my projects and it proved to be well defined)
- create the smallest API possible without dropping useful functionality
- removed the SubConfiguration it doesn't seems to provide much for Velocity
- removed getTypeXX(key), Velocity should start with default values if no configuration is provided, no failures allowed if a configuration is missing(however a ConversionException will be thrown if a conversion to a specific type cannot be performed)
- kept the concept of a configuration listener just in case in the future Velocity will reload itself(parts) at runtime if configuration changes. For performance reasons you don't want to get a configuration value at runtime, you load it during initialisation in a local(instance) variable and register a listener to the configuration if you want to be notified when the configuration changes(to reinitialise your internals)
- kept the concept of keeping the value of a key as an Object, allowing to pass Lists. Also getStringArray/setStringArray looks for a separator(default ",") to get/set lists.
- no support for interpolation, implementations like Apache Commons Configuration will provide such a functionality
- provide a ConfigurationFactory as an entry point to get a configuration(based on a Map, a File or a String) and all implementations are private. Developers can provide obviously their own Configuration implementation and the only restriction is to thread safe(see configuration listener)
Any comments are welcomed.
> Improve configuration facility
> ------------------------------
>
> Key: VELOCITY-790
> URL: https://issues.apache.org/jira/browse/VELOCITY-790
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 2.0
> Reporter: Antonio Petrelli
> Assignee: Adrian Tarau
> Fix For: 2.0
>
>
> Currently the whole configuration of Velocity Engine is managed by ExtendedProperties, a class from Commons Collections.
> An interface that abstracts from this implementation, and an implementation that uses normal Properties should be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-790) Improve configuration facility
Posted by "Nathan Bubna (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969199#action_12969199 ]
Nathan Bubna commented on VELOCITY-790:
---------------------------------------
What's the benefit of having all those converters?
> Improve configuration facility
> ------------------------------
>
> Key: VELOCITY-790
> URL: https://issues.apache.org/jira/browse/VELOCITY-790
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 2.0
> Reporter: Antonio Petrelli
> Assignee: Adrian Tarau
> Fix For: 2.0
>
>
> Currently the whole configuration of Velocity Engine is managed by ExtendedProperties, a class from Commons Collections.
> An interface that abstracts from this implementation, and an implementation that uses normal Properties should be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] [Commented] (VELOCITY-790) Improve configuration facility
Posted by "Claude Brisson (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062879#comment-13062879 ]
Claude Brisson commented on VELOCITY-790:
-----------------------------------------
Any progress on this one, Adrian?
> Improve configuration facility
> ------------------------------
>
> Key: VELOCITY-790
> URL: https://issues.apache.org/jira/browse/VELOCITY-790
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 2.x
> Reporter: Antonio Petrelli
> Assignee: Adrian Tarau
> Fix For: 2.x
>
>
> Currently the whole configuration of Velocity Engine is managed by ExtendedProperties, a class from Commons Collections.
> An interface that abstracts from this implementation, and an implementation that uses normal Properties should be used.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-790) Improve configuration facility
Posted by "Adrian Tarau (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970577#action_12970577 ]
Adrian Tarau commented on VELOCITY-790:
---------------------------------------
It seems like ResourceManagerImpl uses subset so I will keep this feature.
ExtendedProperties loaderConfiguration =
rsvc.getConfiguration().subset(loaderID.toString());
> Improve configuration facility
> ------------------------------
>
> Key: VELOCITY-790
> URL: https://issues.apache.org/jira/browse/VELOCITY-790
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 2.0
> Reporter: Antonio Petrelli
> Assignee: Adrian Tarau
> Fix For: 2.0
>
>
> Currently the whole configuration of Velocity Engine is managed by ExtendedProperties, a class from Commons Collections.
> An interface that abstracts from this implementation, and an implementation that uses normal Properties should be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org