You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Joe Bohn (JIRA)" <de...@geronimo.apache.org> on 2006/05/09 19:45:04 UTC
[jira] Created: (GERONIMO-2001) Eliminate unnecessary CRs in
deployment and other messages
Eliminate unnecessary CRs in deployment and other messages
----------------------------------------------------------
Key: GERONIMO-2001
URL: http://issues.apache.org/jira/browse/GERONIMO-2001
Project: Geronimo
Type: Bug
Security: public (Regular issues)
Components: deployment
Versions: 1.1
Environment: windows XP
Reporter: Joe Bohn
Assigned to: Joe Bohn
Priority: Minor
Fix For: 1.1
There are a number of places (particularly in messages in response to deployments) where extra carriage returns are inserted into the output. This appears to be accidental. The DeployUtil.resolve() method already adds a CR to the end of every formatted line. However, when this is invoked from various places it appears to be 50/50 as to whether println or print is used. Of course println results in an extra CR being inserted into the message. For multi-line messages (such as when deploying an EAR that contains multiple modules) this can be annoying and at least one user has complained that this interfers with scripts that they are using to wrap the commands.
This simply changes any printlns to prints for any messages that are printed using DeployUtil.format().
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (GERONIMO-2001) Eliminate unnecessary CRs in
deployment and other messages
Posted by "Matt Hogstrom (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2001?page=all ]
Matt Hogstrom reassigned GERONIMO-2001:
---------------------------------------
Assign To: Matt Hogstrom (was: Joe Bohn)
> Eliminate unnecessary CRs in deployment and other messages
> ----------------------------------------------------------
>
> Key: GERONIMO-2001
> URL: http://issues.apache.org/jira/browse/GERONIMO-2001
> Project: Geronimo
> Type: Bug
> Security: public(Regular issues)
> Components: deployment
> Versions: 1.1
> Environment: windows XP
> Reporter: Joe Bohn
> Assignee: Matt Hogstrom
> Priority: Minor
> Fix For: 1.1
> Attachments: 2001_FormatMessages.patch
>
> There are a number of places (particularly in messages in response to deployments) where extra carriage returns are inserted into the output. This appears to be accidental. The DeployUtil.resolve() method already adds a CR to the end of every formatted line. However, when this is invoked from various places it appears to be 50/50 as to whether println or print is used. Of course println results in an extra CR being inserted into the message. For multi-line messages (such as when deploying an EAR that contains multiple modules) this can be annoying and at least one user has complained that this interfers with scripts that they are using to wrap the commands.
> This simply changes any printlns to prints for any messages that are printed using DeployUtil.format().
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-2001) Eliminate unnecessary CRs in
deployment and other messages
Posted by "Joe Bohn (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2001?page=all ]
Joe Bohn updated GERONIMO-2001:
-------------------------------
Attachment: 2001_FormatMessages.patch
patch was created on windows xp from geronimo root
> Eliminate unnecessary CRs in deployment and other messages
> ----------------------------------------------------------
>
> Key: GERONIMO-2001
> URL: http://issues.apache.org/jira/browse/GERONIMO-2001
> Project: Geronimo
> Type: Bug
> Security: public(Regular issues)
> Components: deployment
> Versions: 1.1
> Environment: windows XP
> Reporter: Joe Bohn
> Assignee: Joe Bohn
> Priority: Minor
> Fix For: 1.1
> Attachments: 2001_FormatMessages.patch
>
> There are a number of places (particularly in messages in response to deployments) where extra carriage returns are inserted into the output. This appears to be accidental. The DeployUtil.resolve() method already adds a CR to the end of every formatted line. However, when this is invoked from various places it appears to be 50/50 as to whether println or print is used. Of course println results in an extra CR being inserted into the message. For multi-line messages (such as when deploying an EAR that contains multiple modules) this can be annoying and at least one user has complained that this interfers with scripts that they are using to wrap the commands.
> This simply changes any printlns to prints for any messages that are printed using DeployUtil.format().
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (GERONIMO-2001) Eliminate unnecessary CRs in
deployment and other messages
Posted by "Matt Hogstrom (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2001?page=all ]
Matt Hogstrom closed GERONIMO-2001:
-----------------------------------
Resolution: Fixed
Thanks Joe
Sending modules/deploy-tool/src/java/org/apache/geronimo/deployment/cli/AbstractCommand.java
Sending modules/deploy-tool/src/java/org/apache/geronimo/deployment/cli/CommandDistribute.java
Sending modules/deploy-tool/src/java/org/apache/geronimo/deployment/cli/CommandInstallCAR.java
Sending modules/deploy-tool/src/java/org/apache/geronimo/deployment/cli/CommandListConfigurations.java
Sending modules/deploy-tool/src/java/org/apache/geronimo/deployment/cli/CommandLogin.java
Sending modules/deploy-tool/src/java/org/apache/geronimo/deployment/cli/DeployTool.java
Sending modules/deploy-tool/src/java/org/apache/geronimo/deployment/cli/ServerConnection.java
Sending modules/hot-deploy/src/java/org/apache/geronimo/deployment/hot/DirectoryHotDeployer.java
Transmitting file data ........
Committed revision 405624.
> Eliminate unnecessary CRs in deployment and other messages
> ----------------------------------------------------------
>
> Key: GERONIMO-2001
> URL: http://issues.apache.org/jira/browse/GERONIMO-2001
> Project: Geronimo
> Type: Bug
> Security: public(Regular issues)
> Components: deployment
> Versions: 1.1
> Environment: windows XP
> Reporter: Joe Bohn
> Assignee: Matt Hogstrom
> Priority: Minor
> Fix For: 1.1
> Attachments: 2001_FormatMessages.patch
>
> There are a number of places (particularly in messages in response to deployments) where extra carriage returns are inserted into the output. This appears to be accidental. The DeployUtil.resolve() method already adds a CR to the end of every formatted line. However, when this is invoked from various places it appears to be 50/50 as to whether println or print is used. Of course println results in an extra CR being inserted into the message. For multi-line messages (such as when deploying an EAR that contains multiple modules) this can be annoying and at least one user has complained that this interfers with scripts that they are using to wrap the commands.
> This simply changes any printlns to prints for any messages that are printed using DeployUtil.format().
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira