[GitHub] [iceberg] sumeetgajjar commented on a diff in pull request #4825: Test: Fix flaky testOlderThanTimestamp in TestRemoveOrphanFilesAction3

[GitBox <gi...@apache.org>]

sumeetgajjar commented on code in PR #4825:
URL: https://github.com/apache/iceberg/pull/4825#discussion_r878845854


##########
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java:
##########
@@ -420,7 +420,7 @@ public void testOlderThanTimestamp() throws InterruptedException {
 

Review Comment:
   > I can't comment on it, but do any of the other waitUntilAfter calls need this change?
   This is the only place where it is necessary. 
   I took a look at all the other tests in this Suite when I filed the PR, and I did not find any places where we would require such a change.
   
   > as it's two in a row (essentially this is sort of like thread.sleep(1000)).
   Yes, exactly :-)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org