You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/14 13:16:36 UTC
[GitHub] [arrow-rs] alamb opened a new pull request, #2066: Rename `weekday` and `weekday0` kenrels to to `num_days_from_monday` and `days_since_sunday`
alamb opened a new pull request, #2066:
URL: https://github.com/apache/arrow-rs/pull/2066
# Which issue does this PR close?
Closes https://github.com/apache/arrow-rs/issues/2065
# Rationale for this change
Depending on the usecase sometimes one wants the days of week to start from Sunday or Monday. Dates :shrug:
@ovr added the `weekday0` kernel in https://github.com/apache/arrow-rs/pull/2052
But now the names are `weekday` and `weekday0` which I think might be confusing to the average reader
# What changes are included in this PR?
Rename the kernels to follow the chrono naming scheme `num_days_from_sunday` and `num_days_from_monday`
https://docs.rs/chrono/0.4.19/chrono/enum.Weekday.html#method.num_days_from_sunday
https://docs.rs/chrono/0.4.19/chrono/enum.Weekday.html#method.num_days_from_monday
# Are there any user-facing changes?
Yes, name of the `compute::kernels::temporal::weekday` (which is present in arrow 18) is renamed to `compute::kernels::temporal::num_days_since_monday`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #2066: Rename `weekday` and `weekday0` kenrels to to `num_days_from_monday` and `days_since_sunday`
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2066:
URL: https://github.com/apache/arrow-rs/pull/2066#issuecomment-1184438362
cc @nl5887 who contributed the original `weekday` kernel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #2066: Rename `weekday` and `weekday0` kenrels to to `num_days_from_monday` and `days_since_sunday`
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2066:
URL: https://github.com/apache/arrow-rs/pull/2066#issuecomment-1184469807
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2066?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2066](https://codecov.io/gh/apache/arrow-rs/pull/2066?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (43c5f97) into [master](https://codecov.io/gh/apache/arrow-rs/commit/4444cb70607a9f0fe4c0f4130fa03b34faffef9c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4444cb7) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 43c5f97 differs from pull request most recent head 01bb3fb. Consider uploading reports for the commit 01bb3fb to get more accurate results
```diff
@@ Coverage Diff @@
## master #2066 +/- ##
=======================================
Coverage 83.57% 83.57%
=======================================
Files 222 222
Lines 58244 58244
=======================================
+ Hits 48675 48677 +2
+ Misses 9569 9567 -2
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/2066?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/compute/kernels/temporal.rs](https://codecov.io/gh/apache/arrow-rs/pull/2066/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy90ZW1wb3JhbC5ycw==) | `94.98% <100.00%> (ø)` | |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/2066/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `66.21% <0.00%> (+0.22%)` | :arrow_up: |
| [arrow/src/datatypes/datatype.rs](https://codecov.io/gh/apache/arrow-rs/pull/2066/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9kYXRhdHlwZS5ycw==) | `65.68% <0.00%> (+0.36%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2066?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2066?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4444cb7...01bb3fb](https://codecov.io/gh/apache/arrow-rs/pull/2066?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #2066: Rename `weekday` and `weekday0` kernels to to `num_days_from_monday` and `days_since_sunday`
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2066:
URL: https://github.com/apache/arrow-rs/pull/2066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2066: Rename `weekday` and `weekday0` kernels to to `num_days_from_monday` and `days_since_sunday`
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2066:
URL: https://github.com/apache/arrow-rs/pull/2066#issuecomment-1184608230
Benchmark runs are scheduled for baseline = 4444cb70607a9f0fe4c0f4130fa03b34faffef9c and contender = 11445ee1518dfbb4a58215cbc590baa2f3cd8702. 11445ee1518dfbb4a58215cbc590baa2f3cd8702 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2675b2185737447d952b8eb6c51f8e84...687442c52b97425c862eeea0a28a7f02/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/8ffed1c6f45546f88eb61fb5a336d74e...cb3f80f8405d48ef9dd1e3a8e31f9add/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f33b354b397e476c9fff9b78c690a4b9...ea0d67d4acfc4fa4b7dff251dc33274a/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/052691493a6f46a78c46b9b88441959a...cd1fa5fdf65d4fb9b54b07b88295dbe6/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #2066: Rename `weekday` and `weekday0` kernels to to `num_days_from_monday` and `days_since_sunday`
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #2066:
URL: https://github.com/apache/arrow-rs/pull/2066#issuecomment-1184607321
Labelled as development process to hide from changelog (as not released)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #2066: Rename `weekday` and `weekday0` kernels to to `num_days_from_monday` and `days_since_sunday`
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2066:
URL: https://github.com/apache/arrow-rs/pull/2066#issuecomment-1184641595
>
Labelled as development process to hide from changelog (as not released)
I think since `weekday` is released this should be in the changelog
https://docs.rs/arrow/18.0.0/arrow/compute/kernels/temporal/fn.weekday.html
though `weekday0` was not released (perhaps I can update the title)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org