You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by barthel <gi...@git.apache.org> on 2015/10/16 01:43:51 UTC

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

GitHub user barthel opened a pull request:

    https://github.com/apache/maven/pull/70

    MNG-3092: Adds version range result filter behaviour

    The discussion on issue [MNG-3092](https://issues.apache.org/jira/browse/MNG-3092) shows the seriously needs of different kinds of version range resolving in Maven.
    
    I know about the risk on changing the resolving mechanism in Maven.
    I always had the backward compatibility in mind, if I have something changed.
    I added some basic tests for the default version range resolver before I've started with the refactoring.
    
    This pull request contains the basic tests and a less invasive solution based on a filter works with resolved version range results.
    
    The actual version range resolving algorithm **wasn't changed** and the internal used default filter implementation don't filter anything.
    
    The goal:
    Provide a hook for Maven extensions/plugins to change the list of resolved version range results as required.
    
    These changes are only placed in _maven-aether-provider_.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/barthel/maven MNG-3092

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven/pull/70.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #70
    
----
commit cf86c2c4c8e0c070cd800f8a7d2787b3b56d687b
Author: barthel <ba...@users.noreply.github.com>
Date:   2015-04-30T12:37:52Z

    MNG-3092: Adds version range result filter behaviour
    
    The ```DefaultVersionRangeResolver``` will be extends with a filter for
    version range results.
    
    This commit adds a new interfaces ```VersionRangeResultFilter``` and a
    non filtering ```DefaultVersionRangeResultFilter```.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request #70: MNG-3092: Adds version range result filter behaviour

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on a diff in the pull request:

    https://github.com/apache/maven/pull/70#discussion_r67234247
  
    --- Diff: maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java ---
    @@ -88,19 +91,27 @@
         @Requirement
         private RepositoryEventDispatcher repositoryEventDispatcher;
     
    +    @Requirement( role = VersionRangeResultFilter.class, optional = true )
    +    private VersionRangeResultFilter versionRangeResultFilter = new DefaultVersionRangeResultFilter();
    +
         public DefaultVersionRangeResolver()
         {
             // enable default constructor
         }
     
         @Inject
         DefaultVersionRangeResolver( MetadataResolver metadataResolver, SyncContextFactory syncContextFactory,
    -                                 RepositoryEventDispatcher repositoryEventDispatcher, LoggerFactory loggerFactory )
    +            RepositoryEventDispatcher repositoryEventDispatcher, LoggerFactory loggerFactory,
    --- End diff --
    
    Unrelated change, revert!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-174666838
  
    @jvanzyl There are unit tests in the commit. Isn't that enough? Otherwise, I'd ask @barthel for it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-184350865
  
    This commit is huge and has a lot of merge noise. Do you think you can squeeze it down to your changes only?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-148898986
  
    This solution could also be usable for [MNG-5353](https://issues.apache.org/jira/browse/MNG-5353).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-149484847
  
    @barthel Thanks for the update. If you rebase against current master you don't need that property at all. I have added Commons Lang to dependency management already.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-174656884
  
    Can we make any progress here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven issue #70: MNG-3092: Adds version range result filter behaviour

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the issue:

    https://github.com/apache/maven/pull/70
  
    @barthel Perfect, already assigned. Just waiting for an updated PR and all will be merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven issue #70: MNG-3092: Adds version range result filter behaviour

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the issue:

    https://github.com/apache/maven/pull/70
  
    @barthel ITs pass. I am now willing to merge both PRs. Just waiting for your comment on the previous message.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-159078734
  
    Thanks, I will test and merge tomorrow.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-151395866
  
    Can I do anything to support the merge?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-150489457
  
    @michael-o @jvanzyl Let's go merging? :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-159729295
  
    @jvanzyl Did you mean ```@Requirement``` and ```@Component```?
    I'm following the coding style found in the classes around.
    
    Please point me to the replacements for these annotations.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-184327161
  
    Integration test pull request: https://github.com/apache/maven-integration-testing/pull/14


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven issue #70: MNG-6049: Adds version range result filter behaviour

Posted by talios <gi...@git.apache.org>.
Github user talios commented on the issue:

    https://github.com/apache/maven/pull/70
  
    @barthel Maybe, I'm running 3.4.0-SNAPSHOTs anyway, and might pull in your PR to play with and see if it helps with what I'm doing.  My currently problem is that IntelliJ IDEA doesn't seem to execute any lifecycle extensions, so things that affect dependency resolution don't get reflected in IntelliJ ( my process is currently injecting user properties, but I suspect a pluggable dependency selector may also not get picked up ).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven issue #70: MNG-3092: Adds version range result filter behaviour

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the issue:

    https://github.com/apache/maven/pull/70
  
    @michael-o I'm working on integration tests right now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by dinoboy197 <gi...@git.apache.org>.
Github user dinoboy197 commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-185839435
  
    @barthel - I think all you should need to do is to rebase your feature branch (MNG-3092) against upstream/master.
    
    Something like this should do it (assuming that in your git clone, upstream is configured to point to apache/maven and origin is configured to point to barthel/maven):
    * `git fetch upstream`
    * `git checkout MNG-3092`
    * `git rebase upstream/master`
    * `git push -f origin MNG-3092`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request #70: MNG-3092: Adds version range result filter behaviour

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on a diff in the pull request:

    https://github.com/apache/maven/pull/70#discussion_r67234434
  
    --- Diff: maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java ---
    @@ -255,7 +277,7 @@ public VersionRangeResult resolveVersionRange( RepositorySystemSession session,
         }
     
         private Versioning readVersions( RepositorySystemSession session, RequestTrace trace, Metadata metadata,
    -                                     ArtifactRepository repository, VersionRangeResult result )
    +            ArtifactRepository repository, VersionRangeResult result )
    --- End diff --
    
    Unrelated change, revert!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-159728334
  
    @michael-o Indent size and inside issues solved. Commits squashed and amend on last commit in branch.
    What can I do to avoid the merge commit? If I merge the master into this branch a lot more commits are involved here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request #70: MNG-3092: Adds version range result filter behaviour

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on a diff in the pull request:

    https://github.com/apache/maven/pull/70#discussion_r67234360
  
    --- Diff: maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java ---
    @@ -136,15 +152,22 @@ public DefaultVersionRangeResolver setSyncContextFactory( SyncContextFactory syn
         }
     
         public DefaultVersionRangeResolver setRepositoryEventDispatcher(
    -        RepositoryEventDispatcher repositoryEventDispatcher )
    +            RepositoryEventDispatcher repositoryEventDispatcher )
         {
             this.repositoryEventDispatcher = Validate.notNull( repositoryEventDispatcher,
    -            "repositoryEventDispatcher cannot be null" );
    +                "repositoryEventDispatcher cannot be null" );
    +        return this;
    +    }
    +
    +    public DefaultVersionRangeResolver setVersionRangeResultFilter( VersionRangeResultFilter versionRangeResultFilter )
    +    {
    +        this.versionRangeResultFilter = Validate.notNull( versionRangeResultFilter,
    +                "versionRangeResultFilter cannot be null" );
             return this;
         }
     
         public VersionRangeResult resolveVersionRange( RepositorySystemSession session, VersionRangeRequest request )
    -        throws VersionRangeResolutionException
    +            throws VersionRangeResolutionException
    --- End diff --
    
    Unrelated change, revert!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-159045732
  
    @barthel GitHub tells me that this branch has conflicts. Can you kindly check if rebase on top of master if necessary?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-183894970
  
    I suggest looking at more recent integration tests which are similar to yours where there is a default implementation and new implementations can be used. Take a look at MavenITmng5591WorkspaceReader.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-159585971
  
    Just looking through here and you also switch these to use JSR330 annotations instead of the plexus annotations. Any additions I'd like to see use JSR330 which is what we typically do now. I have a large branch which is a mass conversion of everything to JSR330 and it will help if when rebasing that I don't have to convert components again while merging which is what I've been doing for the last year with this branch. I don't mind doing this myself, just let me know.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-185895693
  
    @barthel much but I won't be able to take a closer at it before next week. @jvanzyl if you can do it sooner, just go again and do it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven issue #70: MNG-3092: Adds version range result filter behaviour

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the issue:

    https://github.com/apache/maven/pull/70
  
    Relabelling commit from MNG-3092 to MNG-6049.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-159546743
  
    There are still some issues with the branch. You did not replay on top of master. It is creating a merge commit which I'd like to avoid. Some other issues will be commented inline.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-184304203
  
    @jvanzyl : Thanks for your tip. Now it works. :-D


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven issue #70: MNG-3092: Adds version range result filter behaviour

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the issue:

    https://github.com/apache/maven/pull/70
  
    @barthel Very good. Did you have a chance to work on the other issues I have written?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-159059568
  
    @michael-o see my comment Oct 19:
    > Please remove version property for commons-lang when merging into the master.
    
    That's the rework you suggest with working on [https://issues.apache.org/jira/browse/MNG-5649].


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by pSub <gi...@git.apache.org>.
Github user pSub commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-174664718
  
    I would appreciate a merge, too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-159076106
  
    POM file adapted. Use parent version 3.3.10-SNAPSHOT and remove ```commons-lang``` dependency.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-148556469
  
    @jvanzyl @michael-o : Ready for easier review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-184328357
  
    @jvanzyl @michael-o : Read to merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-151499565
  
    Then I don’t see an issue with merging it.
    
    > On Oct 27, 2015, at 4:38 AM, barthel <no...@github.com> wrote:
    > 
    > The default behavior is do nothing. The ITs doesn't show any errors at this modifications.
    > 
    > —
    > Reply to this email directly or view it on GitHub.
    > 
    
    Thanks,
    
    Jason
    
    ----------------------------------------------------------
    Jason van Zyl
    Founder, Takari and Apache Maven
    http://twitter.com/jvanzyl
    http://twitter.com/takari_io
    ---------------------------------------------------------
    
    A man enjoys his work when he understands the whole and when he
    is responsible for the quality of the whole
    
     -- Christopher Alexander, A Pattern Language
    
    
    
    
    
    
    
    
    
    
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven issue #70: MNG-6049: Adds version range result filter behaviour

Posted by talios <gi...@git.apache.org>.
Github user talios commented on the issue:

    https://github.com/apache/maven/pull/70
  
    @barthel is there an example anywhere of using this?  I have a project (custom lifecycle extension) myself where I think utilizing this will actually make what I'm doing much easier, nicer, and probably more "maven safe".  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request #70: MNG-3092: Adds version range result filter behaviour

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on a diff in the pull request:

    https://github.com/apache/maven/pull/70#discussion_r67234444
  
    --- Diff: maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java ---
    @@ -290,7 +312,7 @@ private Versioning readVersions( RepositorySystemSession session, RequestTrace t
         }
     
         private void invalidMetadata( RepositorySystemSession session, RequestTrace trace, Metadata metadata,
    -                                  ArtifactRepository repository, Exception exception )
    +            ArtifactRepository repository, Exception exception )
    --- End diff --
    
    Unrelated change, revert!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-159774014
  
    @barthel I mean using the JSR330 equivalents for @Component and @Requirement. For @Component we replace them with @Named and @Singleton used together at the class level, and we replace @Requirement with @Inject at the field or constructor level. Generally I think using private final fields and using @Inject on the constructor is the better option. One we do not have with Plexus annotations. An example of a newer component that uses these are:
    
    https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/extension/internal/CoreExportsProvider.java


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-184374596
  
    @michael-o Sorry I've no idea how to remove the merge 'noise' from this really old branch. The only change of mine is ```28fd43d```.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-159062461
  
    @barthel See my inline comments. Then I will take it from there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven issue #70: MNG-3092: Adds version range result filter behaviour

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the issue:

    https://github.com/apache/maven/pull/70
  
    @michael-o Indent changes reverted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-178390879
  
    @jvanzyl , @michael-o : Sorry for the delay. I'm busy right now. I will try to do the change to Maven 3.4 (and JSR330) and add a integration test. But not before friday this week.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on a diff in the pull request:

    https://github.com/apache/maven/pull/70#discussion_r42421297
  
    --- Diff: .gitignore ---
    @@ -13,3 +13,5 @@ out/
     /bootstrap
     /dependencies.xml
     .java-version
    +nb-configuration.xml
    +
    --- End diff --
    
    Not related to the PR, please remove.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request #70: MNG-3092: Adds version range result filter behaviour

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on a diff in the pull request:

    https://github.com/apache/maven/pull/70#discussion_r67234319
  
    --- Diff: maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java ---
    @@ -136,15 +152,22 @@ public DefaultVersionRangeResolver setSyncContextFactory( SyncContextFactory syn
         }
     
         public DefaultVersionRangeResolver setRepositoryEventDispatcher(
    -        RepositoryEventDispatcher repositoryEventDispatcher )
    +            RepositoryEventDispatcher repositoryEventDispatcher )
    --- End diff --
    
    Unrelated change, revert!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on a diff in the pull request:

    https://github.com/apache/maven/pull/70#discussion_r42421348
  
    --- Diff: maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java ---
    @@ -152,6 +154,16 @@ public DefaultVersionRangeResolver setRepositoryEventDispatcher( RepositoryEvent
             return this;
         }
     
    +    public DefaultVersionRangeResolver setVersionRangeResultFilter( VersionRangeResultFilter versionRangeResultFilter )
    +    {
    +        if ( versionRangeResultFilter == null )
    +        {
    +            throw new IllegalArgumentException( "version range result filter has not been specified" );
    +        }
    --- End diff --
    
    Please use Commons Lang as I have done it recently on other modules in Maven.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-159774308
  
    @barthel I ask this to be done because with some recent changes in Sisu I actually have a chance to land my JSR330 branch which entirely removes Plexus from Maven. @mcculls added support for @PostConstruct and @PreDestroy which allows me to replace all uses of the Disposable interface which gets me another chunk of the way. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-159399815
  
    Organize import in ```DefaultVersionRangeResolver``` and squash commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-184308767
  
    Use JSR 330 annotation instead of the Plexus annotation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request #70: MNG-6049: Adds version range result filter behaviour

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/maven/pull/70


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-148634870
  
    @ChristianSchulte Maybe `Rage` is intentional ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by ChristianSchulte <gi...@git.apache.org>.
Github user ChristianSchulte commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-188009400
  
    @barthel: See [c31be833a6f8d9266990a708efe624d09fa06dec](https://github.com/ChristianSchulte/maven/commit/c31be833a6f8d9266990a708efe624d09fa06dec)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-149349259
  
    @michael-o Your review comments are integrated.
    .gitignore cleaned up.
    Apache Commons Lang used instead of ``IllegalArgumentException``.
    Please remove version property for commons-lang when merging into the master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-148653328
  
    @michael-o There is a typo and not a hidden statement. :-D


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request #70: MNG-3092: Adds version range result filter behaviour

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on a diff in the pull request:

    https://github.com/apache/maven/pull/70#discussion_r67234380
  
    --- Diff: maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java ---
    @@ -193,19 +216,18 @@ public VersionRangeResult resolveVersionRange( RepositorySystemSession session,
                 result.setVersions( versions );
             }
     
    -        return result;
    +        return versionRangeResultFilter.filterVersionRangeResult( result );
         }
     
         private Map<String, ArtifactRepository> getVersions( RepositorySystemSession session, VersionRangeResult result,
    -                                                         VersionRangeRequest request )
    +            VersionRangeRequest request )
    --- End diff --
    
    Unrelated change, revert!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-159366801
  
    @barthel Git gives me:
    
    >  git merge --no-commit barthel/MNG-3092
    Auto-merging maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java
    CONFLICT (content): Merge conflict in maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java
    Automatic merge failed; fix conflicts and then commit the result.
    
    Can you resolve and push again to this branch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-159743197
  
    @barthel While I am not a Git expert. I extract a patch/stash fo the work. Branch master, apply stash and commit again. [This](http://stackoverflow.com/q/16358418/696632) is probably worth reading.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven issue #70: MNG-3092: Adds version range result filter behaviour

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the issue:

    https://github.com/apache/maven/pull/70
  
    I would like to look at ```ContextualSnapshotVersionFilter``` solution, if the Aether code was moved back to Apache Maven.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-148659197
  
    @michael-o Your comment on 'old' commit b6d72699c8b0089351f797e217d635424c1ae5a2:
    > Don't! Always through a NPE if null is passed.
    
    :+1: But, I'm oriented on the current used pattern like in #setRepositoryEventDispatcher or #setSyncContextFactory.
    
    > Right, see my ongoing effort on this: https://issues.apache.org/jira/browse/MNG-5649
    
    Should I adapt the other methods? It's not the original intention of this PR.
    Maybe I create a branch and/or new commit with these changes only.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-159011269
  
    I would like to see this changes in the next Maven (3.3.10) release.
    @michael-o @jvanzyl Please don't forget to merge :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-198910133
  
    @dinoboy197: Sorry, I haven't had time to look at @ChristianSchulte suggestion until now.
    @jvanzyl @michael-o: Suggestion: Merge this solution. I'll evaluate the ```ContextualSnapshotVersionFilter``` way in a separate task. If this solution is a equivalent or a better one, I'll start a new pull request for use the way @ChristianSchulte  suggested and removing my solution.
    
    WDYT?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request #70: MNG-3092: Adds version range result filter behaviour

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on a diff in the pull request:

    https://github.com/apache/maven/pull/70#discussion_r67234340
  
    --- Diff: maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java ---
    @@ -136,15 +152,22 @@ public DefaultVersionRangeResolver setSyncContextFactory( SyncContextFactory syn
         }
     
         public DefaultVersionRangeResolver setRepositoryEventDispatcher(
    -        RepositoryEventDispatcher repositoryEventDispatcher )
    +            RepositoryEventDispatcher repositoryEventDispatcher )
         {
             this.repositoryEventDispatcher = Validate.notNull( repositoryEventDispatcher,
    -            "repositoryEventDispatcher cannot be null" );
    +                "repositoryEventDispatcher cannot be null" );
    --- End diff --
    
    Unrelated change, revert!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-174671286
  
    This is what I have expected you to say ;-)
    @barthel or anyone else, can you craft up an IT for that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven issue #70: MNG-3092: Adds version range result filter behaviour

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the issue:

    https://github.com/apache/maven/pull/70
  
    @michael-o Done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-148704373
  
    @ChristianSchulte Typo fixed. Thanks for looking into it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-180504355
  
    It's an old branch. So I merged the actual master into it and use Maven 3.4.0-SNAPSHOT instead.
    
    Only the last commit reflects the MNG-3092 solution.
    
    @jvanzyl : I'll start to work on JSR 330.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request #70: MNG-3092: Adds version range result filter behaviour

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on a diff in the pull request:

    https://github.com/apache/maven/pull/70#discussion_r67234423
  
    --- Diff: maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java ---
    @@ -193,19 +216,18 @@ public VersionRangeResult resolveVersionRange( RepositorySystemSession session,
                 result.setVersions( versions );
             }
     
    -        return result;
    +        return versionRangeResultFilter.filterVersionRangeResult( result );
         }
     
         private Map<String, ArtifactRepository> getVersions( RepositorySystemSession session, VersionRangeResult result,
    -                                                         VersionRangeRequest request )
    +            VersionRangeRequest request )
         {
             RequestTrace trace = RequestTrace.newChild( request.getTrace(), request );
     
             Map<String, ArtifactRepository> versionIndex = new HashMap<>();
     
    -        Metadata metadata =
    -            new DefaultMetadata( request.getArtifact().getGroupId(), request.getArtifact().getArtifactId(),
    -                                 MAVEN_METADATA_XML, Metadata.Nature.RELEASE_OR_SNAPSHOT );
    +        Metadata metadata = new DefaultMetadata( request.getArtifact().getGroupId(),
    +                request.getArtifact().getArtifactId(), MAVEN_METADATA_XML, Metadata.Nature.RELEASE_OR_SNAPSHOT );
    --- End diff --
    
    Unrelated change, revert!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-151463857
  
    The default behavior is ``do nothing``. The ITs doesn't show any errors at this modifications.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by dinoboy197 <gi...@git.apache.org>.
Github user dinoboy197 commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-198031554
  
    @michael-o @jvanzyl @barthel - just checking in to see if any progress has been made on reviewing this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-160448962
  
    I'm busy the next few days. But I will give it a try if these changes have a chance to merge in 3.3.10.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-180506499
  
    Not critical, I can add the annotations later. More important are integration tests if you haven't started those yet. If you have, great!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven issue #70: MNG-3092: Adds version range result filter behaviour

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the issue:

    https://github.com/apache/maven/pull/70
  
    I am already working on your PRs. I think, committing this under MNG-3092 is wrong and will explain why. I we cannot close the issue, people won't see this in the changelog. They won't simply know that a simple extension can solve their problem. Can you create a separate issue for your solution and make MNG-3092 depend on your issue. People would then know that they can solve it by adding an extension. I will change the PR content according to the new issue id.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-174668942
  
    For a feature like that there should be an integration test as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by Jason van Zyl <ja...@takari.io>.
Changing the default behaviour of anything resolution related mid 3.x line is likely not a good idea. We definitely need to run the ITs with any changes like these to see what happens. Changing the way resolution works is definitely a 4.x thing.

> On Oct 27, 2015, at 1:42 AM, michael-o <gi...@git.apache.org> wrote:
> 
> Github user michael-o commented on the pull request:
> 
>    https://github.com/apache/maven/pull/70#issuecomment-151415114
> 
>    @jvanzyl Are you saying that you dislike to change the default behavior, i.e., no merge?  @barthel Did you run the ITs before and after your change?
> 
> 
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
> 

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder, Takari and Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/takari_io
---------------------------------------------------------

Be not afraid of growing slowly, be only afraid of standing still.

 -- Chinese Proverb













---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-151415114
  
    @jvanzyl Are you saying that you dislike to change the default behavior, i.e., no merge?  @barthel Did you run the ITs before and after your change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-174664828
  
    If there are integration tests don't wait for me. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-160451976
  
    We're looking at the new year for the next core release so you have time. I might have my JSR330 changes done by then. I have 15 super nasty uses of Plexus to get around but doable over the holidays.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-148553852
  
    This PR replaced the PR (#68) and based on master and re-created branch MNG-3092. This branch contains the cherry picked b6d7269.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-187570913
  
    @ChristianSchulte : Sounds interesting. I'll take a look on it at the end of this week.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-183661203
  
    @jvanzyl , @michael-o  : I start working on the integration tests. It's more complicated than I thought.
    
    The default handling works but I have difficulties to inject the filter into the ```DefaultVersionRangeResolver```.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-149485116
  
    @jvanzyl Can a I merge this PR into master? Are you OK with that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the pull request:

    https://github.com/apache/maven/pull/70#issuecomment-185894318
  
    @dinoboy197 : Fantastic. Thanks for your help. After reading your post, it sounds so logical.
    
    @michael-o , @jvanzyl : Now the merge comes true? :-D


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request #70: MNG-3092: Adds version range result filter behaviour

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on a diff in the pull request:

    https://github.com/apache/maven/pull/70#discussion_r67234207
  
    --- Diff: maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java ---
    @@ -63,14 +64,16 @@
     import java.util.HashMap;
     import java.util.List;
     import java.util.Map;
    +import javax.inject.Singleton;
     
     /**
      * @author Benjamin Bentmann
      */
     @Named
    -@Component( role = VersionRangeResolver.class )
    +@Singleton
    +@Component( role = VersionRangeResolver.class, hint = "default" )
     public class DefaultVersionRangeResolver
    -    implements VersionRangeResolver, Service
    +        implements VersionRangeResolver, Service
    --- End diff --
    
    Unrelated change, revert!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request #70: MNG-3092: Adds version range result filter behaviour

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on a diff in the pull request:

    https://github.com/apache/maven/pull/70#discussion_r67234272
  
    --- Diff: maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java ---
    @@ -88,19 +91,27 @@
         @Requirement
         private RepositoryEventDispatcher repositoryEventDispatcher;
     
    +    @Requirement( role = VersionRangeResultFilter.class, optional = true )
    +    private VersionRangeResultFilter versionRangeResultFilter = new DefaultVersionRangeResultFilter();
    +
         public DefaultVersionRangeResolver()
         {
             // enable default constructor
         }
     
         @Inject
         DefaultVersionRangeResolver( MetadataResolver metadataResolver, SyncContextFactory syncContextFactory,
    -                                 RepositoryEventDispatcher repositoryEventDispatcher, LoggerFactory loggerFactory )
    +            RepositoryEventDispatcher repositoryEventDispatcher, LoggerFactory loggerFactory,
    +            @Nullable VersionRangeResultFilter versionRangeResultFilter )
    --- End diff --
    
    Indent as above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven issue #70: MNG-6049: Adds version range result filter behaviour

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the issue:

    https://github.com/apache/maven/pull/70
  
    @talios Not yet public. I'll create a public example extension if the 3.4.0 release is available.
    See integration test: https://github.com/apache/maven-integration-testing/pull/14
    Not easy to read, but maybe enough for you?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven issue #70: MNG-3092: Adds version range result filter behaviour

Posted by barthel <gi...@git.apache.org>.
Github user barthel commented on the issue:

    https://github.com/apache/maven/pull/70
  
    @michael-o Please take a look at https://issues.apache.org/jira/browse/MNG-6049


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org