You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2021/06/29 23:08:30 UTC

[GitHub] [samza] MabelYC opened a new pull request #1508: SAMZA-2651:Update failsafe version

MabelYC opened a new pull request #1508:
URL: https://github.com/apache/samza/pull/1508


   Issues: current version of failsafe imported a bug, so we want to update failsafe version to pull in the fix and updates
    
   There are some back-incompatible APIs changes, 
   Changes: Describe major changes, listing each separately.
       1. updated failsafe from 1.1.0 to 2.3.1
       2. Moved `AsyncFailsafe` to `FailsafeExecutor`. `AsycFailsafe` is deleted in 2.3.1. 
       3. Moved AsyncFailsafe#future to FailsafeExecutor#getStageAsync .
       4. Moved `TimeUnit` to `ChronoUnit` in policies. 
       5. Added maxRetries as -1 when maxRetries is not set. The default behavior in Failsafe changed from -1 to 3, so we have to set it to -1 to keep the same behavior as before.
       6. Moved ExecutionContext#getExecutions to ExecutionContext#getAttemptCount
       7. Moved `retryOn` to `abortOn`.
       8. update retryPolicy before create FailsafeExecutor. The APIs changed: Event listeners that are specific to policies, such as onRetry for RetryPolicy, must now be configured through the policy instance. 
    
   Tests: Previous unit tests passed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] MabelYC closed pull request #1508: SAMZA-2651:Update failsafe version

Posted by GitBox <gi...@apache.org>.

MabelYC closed pull request #1508:
URL: https://github.com/apache/samza/pull/1508


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org