[GitHub] [spark] xianyinxin edited a comment on issue #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

[GitBox <gi...@apache.org>]

xianyinxin edited a comment on issue #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2
URL: https://github.com/apache/spark/pull/25115#issuecomment-510725129
 
 
   > I have to agree with the maintenance thing. I get that it's de-acronymizing DML (although I think technically the M is supposed to be "manipulation"), but it's really confusing to draw a distinction between writes and other types of DML. If DELETE can't be one of the string-based capabilities, I'm not sure SupportsWrite makes sense as an interface.
   
   Thank you for the comments @jose-torres . I'm not sure if i get you, pls correct me if I'm wrong. "maintenance" is not the M in DML, even though the maintenance thing and write are all DMLs. Why I separate "maintenance" from `SupportsWrite`, pls see my above comments.
   Maybe we can merge `SupportsWrite` and `SupportsMaintenance`, and add a new `MaintenanceBuilder`(or maybe a better word) in `SupportsWrite`? cc @cloud-fan 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org