You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "bowenliang123 (via GitHub)" <gi...@apache.org> on 2023/03/31 17:23:14 UTC
[GitHub] [kyuubi] bowenliang123 opened a new pull request, #4647: Bump Maven from 3.8.7 to 3.9.1 and Mvnd from 0.9.0 to 1.0-m6
bowenliang123 opened a new pull request, #4647:
URL: https://github.com/apache/kyuubi/pull/4647
…mbedded maven 3.9.1)
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
- bump Maven from 3.8.7 to 3.9.1, 3.9.1 fixed the performance issue [MNG-7677](https://issues.apache.org/jira/browse/MNG-7677) in 3.9.0, release notes: https://maven.apache.org/docs/3.9.1/release-notes.html
- Mvnd from 0.9.0 to 1.0-m6 (with embedded maven 3.9.1), release notes: https://github.com/apache/maven-mvnd/releases/tag/1.0-m6
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] cxzl25 commented on pull request #4647: Bump Maven from 3.8.7 to 3.9.1 and Mvnd from 0.9.0 to 1.0-m6
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on PR #4647:
URL: https://github.com/apache/kyuubi/pull/4647#issuecomment-1504639488
Due to the upgrade of the version of maven, the implementation of http was switched from wagon to aether, and the connection timeout of the two was inconsistent, which caused CI to often fail.
Should we revert this modification first to make CI stable?
### wagon 60s
https://github.com/apache/maven-wagon/blob/master/wagon-provider-api/src/main/java/org/apache/maven/wagon/Wagon.java#L44
### aether 10s
https://github.com/apache/maven-resolver/blob/master/maven-resolver-api/src/main/java/org/eclipse/aether/ConfigurationProperties.java#L93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4647: Bump Maven from 3.8.7 to 3.9.1 and Mvnd from 0.9.0 to 1.0-m6
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #4647:
URL: https://github.com/apache/kyuubi/pull/4647#discussion_r1155246418
##########
build/mvnd:
##########
@@ -95,6 +95,7 @@ function get_os_arch() {
# install mvnd under the build/ folder if needed.
function install_mvnd() {
local MVND_VERSION=$(grep "<mvnd.version>" "${_DIR}/../pom.xml" | head -n1 | awk -F '[<>]' '{print $3}')
+ local MVND_MVN_SHORT_VERSION=$(grep "<mvnd.maven.short.version>" "${_DIR}/../pom.xml" | head -n1 | awk -F '[<>]' '{print $3}')
Review Comment:
Change and move it to the next line
```suggestion
local MVND_MVN_SHORT_VERSION=$(echo MVN_VERSION | awk -F . '{print $1$2}')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4647: Bump Maven from 3.8.7 to 3.9.1 and Mvnd from 0.9.0 to 1.0-m6
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4647:
URL: https://github.com/apache/kyuubi/pull/4647#issuecomment-1504685877
Hi @cxzl25, thanks for the investigation here. The same conclusion and a possible fix to increase connection timeout go to #4692.
I am open to revert this upgrade, but it is more important to figure out how possible way to config the timeout for Maven Resolver as it has been set as default since 3.9.x and 4.x .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 closed pull request #4647: Bump Maven from 3.8.7 to 3.9.1 and Mvnd from 0.9.0 to 1.0-m6
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 closed pull request #4647: Bump Maven from 3.8.7 to 3.9.1 and Mvnd from 0.9.0 to 1.0-m6
URL: https://github.com/apache/kyuubi/pull/4647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] codecov-commenter commented on pull request #4647: Bump Maven from 3.8.7 to 3.9.1 and Mvnd from 0.9.0 to 1.0-m6
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4647:
URL: https://github.com/apache/kyuubi/pull/4647#issuecomment-1492444430
## [Codecov](https://codecov.io/gh/apache/kyuubi/pull/4647?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4647](https://codecov.io/gh/apache/kyuubi/pull/4647?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (10f4a25) into [master](https://codecov.io/gh/apache/kyuubi/commit/726a831c3ec8f9f5754e936211536160e21023ef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (726a831) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #4647 +/- ##
============================================
- Coverage 57.60% 57.59% -0.01%
Complexity 13 13
============================================
Files 579 579
Lines 31956 31956
Branches 4270 4270
============================================
- Hits 18407 18404 -3
Misses 11790 11790
- Partials 1759 1762 +3
```
[see 8 files with indirect coverage changes](https://codecov.io/gh/apache/kyuubi/pull/4647/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4647: Bump Maven from 3.8.7 to 3.9.1 and Mvnd from 0.9.0 to 1.0-m6
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #4647:
URL: https://github.com/apache/kyuubi/pull/4647#discussion_r1155310542
##########
pom.xml:
##########
@@ -109,8 +109,9 @@
<properties>
<java.version>1.8</java.version>
- <maven.version>3.8.7</maven.version>
- <mvnd.version>0.9.0</mvnd.version>
+ <maven.version>3.9.1</maven.version>
+ <mvnd.version>1.0-m6</mvnd.version>
+ <mvnd.maven.short.version>39</mvnd.maven.short.version>
Review Comment:
Thanks for the code suggestion. Applied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4647: Bump Maven from 3.8.7 to 3.9.1 and Mvnd from 0.9.0 to 1.0-m6
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #4647:
URL: https://github.com/apache/kyuubi/pull/4647#discussion_r1155246418
##########
build/mvnd:
##########
@@ -95,6 +95,7 @@ function get_os_arch() {
# install mvnd under the build/ folder if needed.
function install_mvnd() {
local MVND_VERSION=$(grep "<mvnd.version>" "${_DIR}/../pom.xml" | head -n1 | awk -F '[<>]' '{print $3}')
+ local MVND_MVN_SHORT_VERSION=$(grep "<mvnd.maven.short.version>" "${_DIR}/../pom.xml" | head -n1 | awk -F '[<>]' '{print $3}')
Review Comment:
Change and move it to the next line
```suggestion
local MVND_MVN_SHORT_VERSION=$(echo $MVN_VERSION | awk -F . '{print $1$2}')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4647: Bump Maven from 3.8.7 to 3.9.1 and Mvnd from 0.9.0 to 1.0-m6
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #4647:
URL: https://github.com/apache/kyuubi/pull/4647#discussion_r1155246418
##########
build/mvnd:
##########
@@ -95,6 +95,7 @@ function get_os_arch() {
# install mvnd under the build/ folder if needed.
function install_mvnd() {
local MVND_VERSION=$(grep "<mvnd.version>" "${_DIR}/../pom.xml" | head -n1 | awk -F '[<>]' '{print $3}')
+ local MVND_MVN_SHORT_VERSION=$(grep "<mvnd.maven.short.version>" "${_DIR}/../pom.xml" | head -n1 | awk -F '[<>]' '{print $3}')
Review Comment:
Change and move it to the next line
```suggestion
local MVND_MVN_SHORT_VERSION=$(echo "$MVN_VERSION" | awk -F . '{print $1$2}')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4647: Bump Maven from 3.8.7 to 3.9.1 and Mvnd from 0.9.0 to 1.0-m6
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #4647:
URL: https://github.com/apache/kyuubi/pull/4647#discussion_r1155108544
##########
pom.xml:
##########
@@ -109,8 +109,9 @@
<properties>
<java.version>1.8</java.version>
- <maven.version>3.8.7</maven.version>
- <mvnd.version>0.9.0</mvnd.version>
+ <maven.version>3.9.1</maven.version>
+ <mvnd.version>1.0-m6</mvnd.version>
+ <mvnd.maven.short.version>39</mvnd.maven.short.version>
Review Comment:
we don't need it, let's evaluate it in shell script, using `maven.version`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4647: Bump Maven from 3.8.7 to 3.9.1 and Mvnd from 0.9.0 to 1.0-m6
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4647:
URL: https://github.com/apache/kyuubi/pull/4647#issuecomment-1493599221
Thanks, merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org