You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/08/03 02:00:58 UTC
[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #4006: [Feature] Support InPredicate in delete statement
kangkaisen commented on a change in pull request #4006:
URL: https://github.com/apache/incubator-doris/pull/4006#discussion_r464158371
##########
File path: gensrc/proto/olap_file.proto
##########
@@ -181,6 +181,13 @@ enum KeysType {
message DeletePredicatePB {
required int32 version = 1;
repeated string sub_predicates = 2;
+ repeated InPredicatePB in_predicates = 3;
+}
+
+message InPredicatePB {
Review comment:
For protobuf, we prefer optional than required, because we maybe remove or rename `column_name` from `InPredicatePB`. Please change all `required ` to `optional`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org