You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2026/07/28 20:31:22 UTC
[PR] Honour the selected Python version when building docs [airflow]
potiuk opened a new pull request, #70642:
URL: https://github.com/apache/airflow/pull/70642
`breeze build-docs` ignored the requested Python version — it hardcoded breeze's
default (3.10) both for the CI image it looks for and for the shell it runs the
Sphinx build in, because the command never had a `--python` option.
That is what happened in [Publish Docs to S3 run 30392033558](https://github.com/apache/airflow/actions/runs/30392033558):
the workflow built, stashed, restored and loaded `ghcr.io/apache/airflow/main/ci/python3.12`,
and the docs step then went looking for a **3.10** image, did not find one, and
started a full from-scratch rebuild (`--cache-from=…/ci/python3.10:cache-linux-amd64`,
`AIRFLOW_PYTHON_VERSION=3.10.20`) — discarding the image the run had just prepared
and documenting against a different interpreter than the workflow intended.
`build-docs` now takes `--python` (env `PYTHON_MAJOR_MINOR_VERSION`, same as every
other image-using breeze command) and passes it to both `BuildCiParams` and
`ShellParams`. The `publish-docs-to-s3` job also carried a stale hardcoded
`PYTHON_MAJOR_MINOR_VERSION: "3.10"`; it now follows `default-python-version` like
every other job in that workflow.
The docs job in `ci-image-checks.yml` had the same latent bug, but it passes
`default-python-version` (3.10), so nothing changes there — it is now correct by
construction rather than by coincidence.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Opus 5)
Generated-by: Claude Code (Opus 5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Honour the selected Python version when building docs [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #70642:
URL: https://github.com/apache/airflow/pull/70642#issuecomment-5109622916
### Backport failed to create: v3-3-test. View the failure log <a href='https://github.com/apache/airflow/actions/runs/30398681975'> Run details </a>
Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>❌</td>
<td>v3-3-test</td>
<td><a href="https://github.com/apache/airflow/commit/9595a58c01eb4b5ffb102bb5b33dda8388cd17c3"><img src='https://img.shields.io/badge/Commit-9595a58-red' alt='Commit Link'></a></td>
</tr>
</table>
You can attempt to backport this manually by running:
```bash
cherry_picker 9595a58 v3-3-test
```
This should apply the commit to the v3-3-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.
After you have resolved the conflicts, you can continue the backport process by running:
```bash
cherry_picker --continue
```
If you don't have cherry-picker installed, see the [installation guide](https://github.com/apache/airflow/blob/main/dev/README.md#how-to-backport-pr-with-cherry-picker-cli).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Honour the selected Python version when building docs [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #70642:
URL: https://github.com/apache/airflow/pull/70642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org