Re: [PR] Implement preimage for floor function to enable predicate pushdown [datafusion]

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on PR #20059:
URL: https://github.com/apache/datafusion/pull/20059#issuecomment-4032610971

   > I left some extra comments in a resolved comment thread, but I think this needs to be re-assessed?
   > 
   > > This adds a preimage implementation for the floor() function that transforms floor(x) = N into x >= N AND x < N+1
   > 
   > This is the intention of the PR, but I don't think there was anything that ensured the interval is only valid for `Operator::Eq`? Let me know if I'm misunderstanding the `preimage` framework
   
   @drin  can you perhaps help us understand this concern with a specific example?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org