[GitHub] [flink] leonardBang commented on a change in pull request #10774: [FLINK-15485][tests] Reopen tests when blocking issue has been resolved.

[GitBox <gi...@apache.org>]

leonardBang commented on a change in pull request #10774: [FLINK-15485][tests] Reopen tests when blocking issue has been resolved.
URL: https://github.com/apache/flink/pull/10774#discussion_r364575892
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/join/JoinITCase.scala
 ##########
 @@ -94,28 +89,19 @@ class JoinITCase(expectedJoinType: JoinType) extends BatchTestBase {
       ))
   }
 
-  @Ignore // TODO support lazy from source
   @Test
   def testLongHashJoinGenerator(): Unit = {
     if (expectedJoinType == HashJoin) {
-      val sink = (new CollectRowTableSink).configure(Array("c"), Array(Types.STRING))
-      tEnv.registerTableSink("collect", sink)
-      tEnv.insertInto("collect", tEnv.sqlQuery("SELECT c FROM SmallTable3, Table5 WHERE b = e"))
-      var haveTwoOp = false
-      env.getStreamGraph.getAllOperatorFactory.foreach(o =>
 
 Review comment:
   This is a ITcase, so I modify and compare the final result.
   what's meaning of `this...`? ,I'm a little confused.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services