You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2017/08/04 16:14:31 UTC

[GitHub] brooklyn-server pull request #792: Remove `org.ow2.asm` (already included in...

GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/792

    Remove `org.ow2.asm` (already included in Karaf)

    I added this in https://github.com/apache/brooklyn-server/pull/784, but turns out that broke karaf!
    
    Including `org.ow2.asm:5.0.4` breaks things badly:
    
    ```
    Caused by: java.lang.ClassNotFoundException: org.objectweb.asm.commons.AdviceAdapter not found by org.apache.aries.proxy.impl [20]
    ```
    
    `org.ow2.asm.all:5.0.2` is already included in karaf; we'll just rely on that instead:
    ```
    ASM all classes with debug info (49)
    ------------------------------------
    Bnd-LastModified = 1398065775616
    Created-By = 1.8.0 (Oracle Corporation)
    Implementation-Title = ASM all classes
    Implementation-Vendor = France Telecom R&D
    Implementation-Version = 5.0.2
    Manifest-Version = 1.0
    Tool = Bnd-1.50.0
    
    Bundle-DocURL = http://asm.objectweb.org
    Bundle-ManifestVersion = 2
    Bundle-Name = ASM all classes with debug info
    Bundle-RequiredExecutionEnvironment = J2SE-1.3
    Bundle-SymbolicName = org.objectweb.asm.all
    Bundle-UpdateLocation = mvn:org.ow2.asm/asm-all/5.0.2
    Bundle-Vendor = France Telecom R&D
    Bundle-Version = 5.0.2
    
    Export-Package = 
    	org.objectweb.asm.signature;version=5.0.2,
    	org.objectweb.asm.commons;uses:="org.objectweb.asm,org.objectweb.asm.tree,org.objectweb.asm.signature";version=5.0.2,
    	org.objectweb.asm.util;uses:="org.objectweb.asm,org.objectweb.asm.tree.analysis,org.objectweb.asm.tree,org.objectweb.asm.signature";version=5.0.2,
    	org.objectweb.asm.tree.analysis;uses:="org.objectweb.asm,org.objectweb.asm.tree";version=5.0.2,
    	org.objectweb.asm;version=5.0.2,
    	org.objectweb.asm.xml;uses:="org.xml.sax,org.objectweb.asm,org.xml.sax.helpers,org.xml.sax.ext,javax.xml.transform.sax,javax.xml.transform,javax.xml.transform.stream,org.objectweb.asm.util";version=5.0.2,
    	org.objectweb.asm.tree;uses:=org.objectweb.asm;version=5.0.2
    Import-Package = 
    	javax.xml.transform;resolution:=optional,
    	javax.xml.transform.sax;resolution:=optional,
    	javax.xml.transform.stream;resolution:=optional,
    	org.xml.sax;resolution:=optional,
    	org.xml.sax.ext;resolution:=optional,
    	org.xml.sax.helpers;resolution:=optional
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server fix-karaf-ow2.asm

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/792.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #792
    
----
commit d873d8d678a32984be702d8fb95b2f19716ded4a
Author: Aled Sage <al...@gmail.com>
Date:   2017-08-04T16:10:47Z

    Remove `org.ow2.asm` (already included in Karaf)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #792: Remove `org.ow2.asm` (already included in...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/792


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---