You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-commits@lucene.apache.org by ko...@apache.org on 2008/09/19 17:26:00 UTC
svn commit: r697132 - in /lucene/solr/trunk/client/java/solrj: CHANGES.txt
src/org/apache/solr/client/solrj/SolrQuery.java
test/org/apache/solr/client/solrj/SolrQueryTest.java
Author: koji
Date: Fri Sep 19 08:25:59 2008
New Revision: 697132
URL: http://svn.apache.org/viewvc?rev=697132&view=rev
Log:
SOLR-779: SolrQuery#setHighlightRequireFieldMatch() should be renamed to SolrQuery#getHighlightRequireFieldMatch().
Modified:
lucene/solr/trunk/client/java/solrj/CHANGES.txt
lucene/solr/trunk/client/java/solrj/src/org/apache/solr/client/solrj/SolrQuery.java
lucene/solr/trunk/client/java/solrj/test/org/apache/solr/client/solrj/SolrQueryTest.java
Modified: lucene/solr/trunk/client/java/solrj/CHANGES.txt
URL: http://svn.apache.org/viewvc/lucene/solr/trunk/client/java/solrj/CHANGES.txt?rev=697132&r1=697131&r2=697132&view=diff
==============================================================================
--- lucene/solr/trunk/client/java/solrj/CHANGES.txt (original)
+++ lucene/solr/trunk/client/java/solrj/CHANGES.txt Fri Sep 19 08:25:59 2008
@@ -28,6 +28,10 @@
1. SOLR-778: SolrQuery#getFacetMinCount() returns value of facet limit
(Kohei Taketa via shalin)
+ 2. SOLR-779: SolrQuery#setHighlightRequireFieldMatch() should be renamed to
+ SolrQuery#getHighlightRequireFieldMatch()
+ (Kohei Taketa, Lars Kotthoff via koji)
+
Documentation
----------------------
Modified: lucene/solr/trunk/client/java/solrj/src/org/apache/solr/client/solrj/SolrQuery.java
URL: http://svn.apache.org/viewvc/lucene/solr/trunk/client/java/solrj/src/org/apache/solr/client/solrj/SolrQuery.java?rev=697132&r1=697131&r2=697132&view=diff
==============================================================================
--- lucene/solr/trunk/client/java/solrj/src/org/apache/solr/client/solrj/SolrQuery.java (original)
+++ lucene/solr/trunk/client/java/solrj/src/org/apache/solr/client/solrj/SolrQuery.java Fri Sep 19 08:25:59 2008
@@ -261,7 +261,7 @@
return this;
}
- public boolean setHighlightRequireFieldMatch() {
+ public boolean getHighlightRequireFieldMatch() {
return this.getBool(HighlightParams.FIELD_MATCH, false);
}
Modified: lucene/solr/trunk/client/java/solrj/test/org/apache/solr/client/solrj/SolrQueryTest.java
URL: http://svn.apache.org/viewvc/lucene/solr/trunk/client/java/solrj/test/org/apache/solr/client/solrj/SolrQueryTest.java?rev=697132&r1=697131&r2=697132&view=diff
==============================================================================
--- lucene/solr/trunk/client/java/solrj/test/org/apache/solr/client/solrj/SolrQueryTest.java (original)
+++ lucene/solr/trunk/client/java/solrj/test/org/apache/solr/client/solrj/SolrQueryTest.java Fri Sep 19 08:25:59 2008
@@ -96,4 +96,22 @@
q.setFacetSort(false);
assertFalse("expected set value to be false", q.getFacetSort());
}
+
+ public void testSettersGetters() {
+ SolrQuery q = new SolrQuery("foo");
+ assertEquals(10, q.setFacetLimit(10).getFacetLimit());
+ assertEquals(10, q.setFacetMinCount(10).getFacetMinCount());
+ assertEquals(true, q.setFacetSort(true).getFacetSort());
+ assertEquals(10, q.setHighlightSnippets(10).getHighlightSnippets());
+ assertEquals(10, q.setHighlightFragsize(10).getHighlightFragsize());
+ assertEquals(true, q.setHighlightRequireFieldMatch(true).getHighlightRequireFieldMatch());
+ assertEquals("foo", q.setHighlightSimplePre("foo").getHighlightSimplePre());
+ assertEquals("foo", q.setHighlightSimplePost("foo").getHighlightSimplePost());
+ assertEquals(true, q.setHighlight(true).getHighlight());
+ assertEquals("foo", q.setQuery("foo").getQuery());
+ assertEquals(10, q.setRows(10).getRows().intValue());
+ assertEquals(10, q.setStart(10).getStart().intValue());
+ assertEquals("foo", q.setQueryType("foo").getQueryType());
+ assertEquals(10, q.setTimeAllowed(10).getTimeAllowed().intValue());
+ }
}