You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:23:04 UTC
[GitHub] [hbase] alexandermyasnikov opened a new pull request #1775: fix building cpp-example DemoClient
alexandermyasnikov opened a new pull request #1775:
URL: https://github.com/apache/hbase/pull/1775
Changed boost::shared_ptr to std::shared_ptr for compatibility with apache thrift v0.13.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bharathv commented on a change in pull request #1775: fix building cpp-example DemoClient
Posted by GitBox <gi...@apache.org>.
bharathv commented on a change in pull request #1775:
URL: https://github.com/apache/hbase/pull/1775#discussion_r430167887
##########
File path: hbase-examples/src/main/cpp/DemoClient.cpp
##########
@@ -79,15 +78,15 @@ main(int argc, char** argv)
return -1;
}
bool isFramed = false;
- boost::shared_ptr<TTransport> socket(new TSocket(argv[1], boost::lexical_cast<int>(argv[2])));
- boost::shared_ptr<TTransport> transport;
+ std::shared_ptr<TTransport> socket(new TSocket(argv[1], std::stoi(argv[2])));
Review comment:
nit: switch to make_shared while you are here?
##########
File path: hbase-examples/src/main/cpp/DemoClient.cpp
##########
@@ -79,15 +78,15 @@ main(int argc, char** argv)
return -1;
}
bool isFramed = false;
- boost::shared_ptr<TTransport> socket(new TSocket(argv[1], boost::lexical_cast<int>(argv[2])));
- boost::shared_ptr<TTransport> transport;
+ std::shared_ptr<TTransport> socket(std::make_shared<TSocket>(argv[1], std::stoi(argv[2])));
Review comment:
I think you mean socket = make_shared<TSocket>.....
With your code, I think it calls into the move constructor..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1775: HBASE-24434 Fix building cpp-example DemoClient
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1775:
URL: https://github.com/apache/hbase/pull/1775#issuecomment-634473216
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 32s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 5s | master passed |
| -0 :warning: | javadoc | 0m 22s | hbase-examples in master failed. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 55s | the patch passed |
| -0 :warning: | javadoc | 0m 18s | hbase-examples in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 1s | hbase-examples in the patch passed. |
| | | 15m 19s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1775/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1775 |
| Optional Tests | javac javadoc unit |
| uname | Linux cb82a98b6e5a 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 476cb16232 |
| Default Java | 2020-01-14 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1775/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-examples.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1775/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-examples.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1775/3/testReport/ |
| Max. process+thread count | 1854 (vs. ulimit of 12500) |
| modules | C: hbase-examples U: hbase-examples |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1775/3/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1775: HBASE-24434 Fix building cpp-example DemoClient
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1775:
URL: https://github.com/apache/hbase/pull/1775#issuecomment-634472481
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 32s | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 14s | master passed |
| +1 :green_heart: | javadoc | 0m 21s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 53s | the patch passed |
| +1 :green_heart: | javadoc | 0m 20s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 14s | hbase-examples in the patch passed. |
| | | 13m 38s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1775/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1775 |
| Optional Tests | javac javadoc unit |
| uname | Linux 4069191f7606 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 476cb16232 |
| Default Java | 1.8.0_232 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1775/3/testReport/ |
| Max. process+thread count | 1909 (vs. ulimit of 12500) |
| modules | C: hbase-examples U: hbase-examples |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1775/3/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1775: fix building cpp-example DemoClient
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1775:
URL: https://github.com/apache/hbase/pull/1775#issuecomment-633683883
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bharathv merged pull request #1775: HBASE-24434 Fix building cpp-example DemoClient
Posted by GitBox <gi...@apache.org>.
bharathv merged pull request #1775:
URL: https://github.com/apache/hbase/pull/1775
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] alexandermyasnikov commented on a change in pull request #1775: fix building cpp-example DemoClient
Posted by GitBox <gi...@apache.org>.
alexandermyasnikov commented on a change in pull request #1775:
URL: https://github.com/apache/hbase/pull/1775#discussion_r430204749
##########
File path: hbase-examples/src/main/cpp/DemoClient.cpp
##########
@@ -79,15 +78,15 @@ main(int argc, char** argv)
return -1;
}
bool isFramed = false;
- boost::shared_ptr<TTransport> socket(new TSocket(argv[1], boost::lexical_cast<int>(argv[2])));
- boost::shared_ptr<TTransport> transport;
+ std::shared_ptr<TTransport> socket(new TSocket(argv[1], std::stoi(argv[2])));
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1775: HBASE-24434 Fix building cpp-example DemoClient
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1775:
URL: https://github.com/apache/hbase/pull/1775#issuecomment-634467734
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. |
| | | 2m 1s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1775/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1775 |
| Optional Tests | dupname asflicense cc golang |
| uname | Linux d5a2459f0b08 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 476cb16232 |
| Max. process+thread count | 47 (vs. ulimit of 12500) |
| modules | C: hbase-examples U: hbase-examples |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1775/3/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org