You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/10/06 22:09:36 UTC
[GitHub] [helix] kaisun2000 opened a new pull request #1445: Make ClusterStateVerifier closable
kaisun2000 opened a new pull request #1445:
URL: https://github.com/apache/helix/pull/1445
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR description:
fix #1444
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
ClusterStateVerifier need to be closable. Otherwise, we may leak
ZooKeeper client session together with ZkClient. That is thread
leakage with memory leakage and potentially Zookeeper server
resource hogging.
Address comments in #1227
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- [x] The following is the result of the "mvn test" command on the appropriate module:
git hub link
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] alirezazamani merged pull request #1445: Make ClusterStateVerifier closable
Posted by GitBox <gi...@apache.org>.
alirezazamani merged pull request #1445:
URL: https://github.com/apache/helix/pull/1445
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 commented on pull request #1445: Make ClusterStateVerifier closable
Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on pull request #1445:
URL: https://github.com/apache/helix/pull/1445#issuecomment-704636135
> "This class is deprecated, please use dedicated verifier classes, such as BestPossibleExternalViewVerifier, etc, in tools.ClusterVerifiers."
>
> Is it possible that we just stop using this class?
@jiajunwang, theoretically, you are right. On the other hand, we did not really remove deprecated class usage in other place of the code. Let us limit the scope of breaking down #1227.
How about let create a separate issue to track "removing usage of deprecated ClusterVerifier"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 edited a comment on pull request #1445: Make ClusterStateVerifier closable
Posted by GitBox <gi...@apache.org>.
kaisun2000 edited a comment on pull request #1445:
URL: https://github.com/apache/helix/pull/1445#issuecomment-704636135
> "This class is deprecated, please use dedicated verifier classes, such as BestPossibleExternalViewVerifier, etc, in tools.ClusterVerifiers."
>
> Is it possible that we just stop using this class?
@jiajunwang, theoretically, you are right. On the other hand, we did not remove other deprecated class usage in our code base. We need to limit the scope of breaking up #1227.
How about let create a separate issue to track "removing usage of deprecated ClusterVerifier"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 commented on pull request #1445: Make ClusterStateVerifier closable
Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on pull request #1445:
URL: https://github.com/apache/helix/pull/1445#issuecomment-705149843
This pull is approved. Please help to merge
>fix #1444
ClusterStateVerifier need to be closable. Otherwise, we may leak
ZooKeeper client session together with ZkClient. That is thread
leakage with memory leakage and potentially Zookeeper server
resource hogging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org