You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Eugene Chekanskiy <ec...@hortonworks.com> on 2017/05/08 11:24:50 UTC
Review Request 59045: Insecure SSL: Server Identity Verification
Disabled
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59045/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi Brodetskyi.
Bugs: AMBARI-20953
https://issues.apache.org/jira/browse/AMBARI-20953
Repository: ambari
Description
-------
Added option
[security]
ca_cert_path=/path/to/pem/formatted/cert/file.pem
to agent configuration.
All requests that using https will use file.pem certificates to validate responce from server.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 16fb97d
ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 28574cc
ambari-agent/src/main/python/ambari_agent/NetUtil.py fc19605
ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 79b1c3b
ambari-common/src/main/python/ambari_commons/inet_utils.py d44107d
ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py 557db58
ambari-common/src/main/python/resource_management/libraries/script/script.py bafb8e2
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py c9b63ff
Diff: https://reviews.apache.org/r/59045/diff/1/
Testing
-------
mvn clean test
Thanks,
Eugene Chekanskiy
Re: Review Request 59045: Insecure SSL: Server Identity Verification
Disabled
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59045/#review174159
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Травень 8, 2017, 11:24 до полудня, Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59045/
> -----------------------------------------------------------
>
> (Updated Травень 8, 2017, 11:24 до полудня)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20953
> https://issues.apache.org/jira/browse/AMBARI-20953
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added option
>
> [security]
> ca_cert_path=/path/to/pem/formatted/cert/file.pem
>
> to agent configuration.
> All requests that using https will use file.pem certificates to validate responce from server.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 16fb97d
> ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 28574cc
> ambari-agent/src/main/python/ambari_agent/NetUtil.py fc19605
> ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 79b1c3b
> ambari-common/src/main/python/ambari_commons/inet_utils.py d44107d
> ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py 557db58
> ambari-common/src/main/python/resource_management/libraries/script/script.py bafb8e2
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py c9b63ff
>
>
> Diff: https://reviews.apache.org/r/59045/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>
Re: Review Request 59045: Insecure SSL: Server Identity Verification
Disabled
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59045/#review174185
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On May 8, 2017, 7:26 p.m., Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59045/
> -----------------------------------------------------------
>
> (Updated May 8, 2017, 7:26 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20953
> https://issues.apache.org/jira/browse/AMBARI-20953
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added option
>
> [security]
> ca_cert_path=/path/to/pem/formatted/cert/file.pem
>
> to agent configuration.
> All requests that using https will use file.pem certificates to validate responce from server.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 16fb97d
> ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 28574cc
> ambari-agent/src/main/python/ambari_agent/NetUtil.py fc19605
> ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 79b1c3b
> ambari-common/src/main/python/ambari_commons/inet_utils.py d44107d
> ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py 557db58
> ambari-common/src/main/python/resource_management/libraries/script/script.py bafb8e2
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py c9b63ff
>
>
> Diff: https://reviews.apache.org/r/59045/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>
Re: Review Request 59045: Insecure SSL: Server Identity Verification
Disabled
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59045/#review174204
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On May 8, 2017, 4:26 p.m., Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59045/
> -----------------------------------------------------------
>
> (Updated May 8, 2017, 4:26 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20953
> https://issues.apache.org/jira/browse/AMBARI-20953
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added option
>
> [security]
> ca_cert_path=/path/to/pem/formatted/cert/file.pem
>
> to agent configuration.
> All requests that using https will use file.pem certificates to validate responce from server.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 16fb97d
> ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 28574cc
> ambari-agent/src/main/python/ambari_agent/NetUtil.py fc19605
> ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 79b1c3b
> ambari-common/src/main/python/ambari_commons/inet_utils.py d44107d
> ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py 557db58
> ambari-common/src/main/python/resource_management/libraries/script/script.py bafb8e2
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py c9b63ff
>
>
> Diff: https://reviews.apache.org/r/59045/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>
Re: Review Request 59045: Insecure SSL: Server Identity Verification
Disabled
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59045/#review174205
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
ambari-common/src/main/python/resource_management/libraries/script/script.py
Lines 284 (patched)
<https://reviews.apache.org/r/59045/#comment247327>
Maybe the view on RB is messed up, but it seems like `9` and `and` need a space between them...
`9and not` --> `9 and not`
- Robert Levas
On May 8, 2017, 12:26 p.m., Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59045/
> -----------------------------------------------------------
>
> (Updated May 8, 2017, 12:26 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20953
> https://issues.apache.org/jira/browse/AMBARI-20953
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added option
>
> [security]
> ca_cert_path=/path/to/pem/formatted/cert/file.pem
>
> to agent configuration.
> All requests that using https will use file.pem certificates to validate responce from server.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 16fb97d
> ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 28574cc
> ambari-agent/src/main/python/ambari_agent/NetUtil.py fc19605
> ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 79b1c3b
> ambari-common/src/main/python/ambari_commons/inet_utils.py d44107d
> ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py 557db58
> ambari-common/src/main/python/resource_management/libraries/script/script.py bafb8e2
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py c9b63ff
>
>
> Diff: https://reviews.apache.org/r/59045/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>
Re: Review Request 59045: Insecure SSL: Server Identity Verification
Disabled
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59045/#review174217
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On May 8, 2017, 3:13 p.m., Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59045/
> -----------------------------------------------------------
>
> (Updated May 8, 2017, 3:13 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20953
> https://issues.apache.org/jira/browse/AMBARI-20953
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added option
>
> [security]
> ca_cert_path=/path/to/pem/formatted/cert/file.pem
>
> to agent configuration.
> All requests that using https will use file.pem certificates to validate responce from server.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 16fb97d
> ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 28574cc
> ambari-agent/src/main/python/ambari_agent/NetUtil.py fc19605
> ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 79b1c3b
> ambari-common/src/main/python/ambari_commons/inet_utils.py d44107d
> ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py 557db58
> ambari-common/src/main/python/resource_management/libraries/script/script.py bafb8e2
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py c9b63ff
>
>
> Diff: https://reviews.apache.org/r/59045/diff/3/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>
Re: Review Request 59045: Insecure SSL: Server Identity Verification
Disabled
Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59045/
-----------------------------------------------------------
(Updated May 8, 2017, 7:13 p.m.)
Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi Brodetskyi.
Bugs: AMBARI-20953
https://issues.apache.org/jira/browse/AMBARI-20953
Repository: ambari
Description
-------
Added option
[security]
ca_cert_path=/path/to/pem/formatted/cert/file.pem
to agent configuration.
All requests that using https will use file.pem certificates to validate responce from server.
Diffs (updated)
-----
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 16fb97d
ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 28574cc
ambari-agent/src/main/python/ambari_agent/NetUtil.py fc19605
ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 79b1c3b
ambari-common/src/main/python/ambari_commons/inet_utils.py d44107d
ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py 557db58
ambari-common/src/main/python/resource_management/libraries/script/script.py bafb8e2
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py c9b63ff
Diff: https://reviews.apache.org/r/59045/diff/3/
Changes: https://reviews.apache.org/r/59045/diff/2-3/
Testing
-------
mvn clean test
Thanks,
Eugene Chekanskiy
Re: Review Request 59045: Insecure SSL: Server Identity Verification
Disabled
Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59045/
-----------------------------------------------------------
(Updated May 8, 2017, 4:26 p.m.)
Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi Brodetskyi.
Changes
-------
fixed import issue, docs
Bugs: AMBARI-20953
https://issues.apache.org/jira/browse/AMBARI-20953
Repository: ambari
Description
-------
Added option
[security]
ca_cert_path=/path/to/pem/formatted/cert/file.pem
to agent configuration.
All requests that using https will use file.pem certificates to validate responce from server.
Diffs (updated)
-----
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 16fb97d
ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 28574cc
ambari-agent/src/main/python/ambari_agent/NetUtil.py fc19605
ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 79b1c3b
ambari-common/src/main/python/ambari_commons/inet_utils.py d44107d
ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py 557db58
ambari-common/src/main/python/resource_management/libraries/script/script.py bafb8e2
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py c9b63ff
Diff: https://reviews.apache.org/r/59045/diff/2/
Changes: https://reviews.apache.org/r/59045/diff/1-2/
Testing
-------
mvn clean test
Thanks,
Eugene Chekanskiy