You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/07/13 05:34:32 UTC

[GitHub] [skywalking] wu-sheng edited a comment on issue #3065: Propose a API change : AbstractTracerContext#asyncStop and AsyncSpan#asyncFinish return boolean

wu-sheng edited a comment on issue #3065: Propose a API change : AbstractTracerContext#asyncStop and AsyncSpan#asyncFinish return boolean
URL: https://github.com/apache/skywalking/pull/3065#issuecomment-511090926
 
 
   The truth is, you could make connection leak if you use the connection pool in wrong way, and crash application. Nothing could stop you to do that.
   
   Also, the thing you said about the check, is even not performance related, it is just wrong. You are solving a question and bringing more to the core.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services