You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/02/11 10:07:53 UTC
[GitHub] [camel-k-runtime] squakez opened a new pull request #628: fix(runtime): singleton config source provider
squakez opened a new pull request #628:
URL: https://github.com/apache/camel-k-runtime/pull/628
Created a singleton to workaround an issue on Quarkus side which is calling the method twice at runtime.
Ref #625
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
fix(runtime): singleton config source provider
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] squakez commented on pull request #628: fix(runtime): singleton config source provider
Posted by GitBox <gi...@apache.org>.
squakez commented on pull request #628:
URL: https://github.com/apache/camel-k-runtime/pull/628#issuecomment-805886393
We can close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli commented on pull request #628: fix(runtime): singleton config source provider
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on pull request #628:
URL: https://github.com/apache/camel-k-runtime/pull/628#issuecomment-805737738
@squakez what should we do with this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli edited a comment on pull request #628: fix(runtime): singleton config source provider
Posted by GitBox <gi...@apache.org>.
lburgazzoli edited a comment on pull request #628:
URL: https://github.com/apache/camel-k-runtime/pull/628#issuecomment-805737738
@squakez what should we do with this PR ? I think we should either close it or make it a draft
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] squakez edited a comment on pull request #628: fix(runtime): singleton config source provider
Posted by GitBox <gi...@apache.org>.
squakez edited a comment on pull request #628:
URL: https://github.com/apache/camel-k-runtime/pull/628#issuecomment-778116320
Unfortunately this patch cannot work for native images. As shown by the integration tests, when the integration are running in native mode we try to initialize the properties during augmentation phase. At that stage we don't have yet any system property or environment variables. I tried delaying the fetching at a later stage by checking the presence of those system properties, resulting in a failure cause Quarkus remove the class as it marks as not used (producing a runtime error later). Probably does not make sense to go ahead until Quarkus team find a proper solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] squakez commented on pull request #628: fix(runtime): singleton config source provider
Posted by GitBox <gi...@apache.org>.
squakez commented on pull request #628:
URL: https://github.com/apache/camel-k-runtime/pull/628#issuecomment-778116320
Unfortunately this patch cannot work for native images. As shown by the integration tests, when the integration are running in native mode we try to initialize the properties during augmentation phase. At that stage we don't have yet any system property or environment variables. I tried delaying the fetching at a later stage by checking the presence of those system properties, resulting in a failure cause Quarkus remove the class as it marks as not used (producing a runtime error). Probably does not make sense to go ahead until Quarkus team find a proper solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] squakez closed pull request #628: fix(runtime): singleton config source provider
Posted by GitBox <gi...@apache.org>.
squakez closed pull request #628:
URL: https://github.com/apache/camel-k-runtime/pull/628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] squakez edited a comment on pull request #628: fix(runtime): singleton config source provider
Posted by GitBox <gi...@apache.org>.
squakez edited a comment on pull request #628:
URL: https://github.com/apache/camel-k-runtime/pull/628#issuecomment-778116320
Unfortunately this patch cannot work for native images. As shown by the integration tests, when the integration are running in native mode we try to initialize the properties during augmentation phase. At that stage we don't have yet any system property or environment variables. I tried delaying the fetching at a later stage by checking the presence of those system properties. It results in a failure because Quarkus removes the class, marking it as not used (and producing a runtime error later). Probably does not make sense to go ahead until Quarkus team find a proper solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org