[GitHub] [activemq-artemis] TomasHofman commented on a change in pull request #3412: ARTEMIS-3074 Add ActiveMQServerControl#createBridge() method variant …

[GitBox <gi...@apache.org>]

TomasHofman commented on a change in pull request #3412:
URL: https://github.com/apache/activemq-artemis/pull/3412#discussion_r560944089



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java
##########
@@ -3796,19 +3796,58 @@ public void createBridge(final String name,
                             final boolean ha,
                             final String user,
                             final String password) throws Exception {
+      createBridge(name,
+              queueName,
+              forwardingAddress,
+              filterString,
+              transformerClassName,
+              retryInterval,
+              retryIntervalMultiplier,
+              initialConnectAttempts,
+              reconnectAttempts,
+              useDuplicateDetection,
+              confirmationWindowSize,
+              clientFailureCheckPeriod,
+              staticConnectorsOrDiscoveryGroup,
+              useDiscoveryGroup,
+              ha,
+              user,
+              password,
+              ActiveMQClient.DEFAULT_CALL_TIMEOUT);
+   }
+
+   @Override
+   public void createBridge(final String name,
+                            final String queueName,
+                            final String forwardingAddress,
+                            final String filterString,
+                            final String transformerClassName,
+                            final long retryInterval,
+                            final double retryIntervalMultiplier,
+                            final int initialConnectAttempts,
+                            final int reconnectAttempts,
+                            final boolean useDuplicateDetection,
+                            final int confirmationWindowSize,
+                            final long clientFailureCheckPeriod,
+                            final String staticConnectorsOrDiscoveryGroup,
+                            boolean useDiscoveryGroup,
+                            final boolean ha,
+                            final String user,
+                            final String password,
+                            final long callTimeout) throws Exception {
       if (AuditLogger.isEnabled()) {
          AuditLogger.createBridge(this.server, name, queueName, forwardingAddress, filterString,
                   transformerClassName, retryInterval, retryIntervalMultiplier, initialConnectAttempts,
                   reconnectAttempts, useDuplicateDetection, confirmationWindowSize, clientFailureCheckPeriod,
-                  staticConnectorsOrDiscoveryGroup, useDiscoveryGroup, ha, user, "****");
+                  staticConnectorsOrDiscoveryGroup, useDiscoveryGroup, ha, user, "****", callTimeout);
       }
       checkStarted();
 
       clearIO();
 
       try {
          TransformerConfiguration transformerConfiguration = transformerClassName == null ? null : new TransformerConfiguration(transformerClassName);

Review comment:
       Fixed in the master branch in the mean time. :+1: 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org