You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by Imteyaz Khan <kh...@gmail.com> on 2018/12/26 19:24:13 UTC
travis ci are failing
Hi all,
Travis CI are failing currently due to log size. Is it the same issue
3052 <https://github.com/apache/incubator-dubbo/issues/3052>?
Re: travis ci are failing
Posted by Huxing Zhang <hu...@apache.org>.
Hi,
I am looking at your pull request[1], travis CI says that it fails due
to log size limit has been exceeded.
I checked the log file, I see lots of exceptions thrown there. For example:
grep -c "NumberFormatException" CI.log
708
But I didn't see that in master Travis CI log.
Could you please check why there is so many NumberFormatException thrown there?
I am not sure what is going on there, but I did see something we can improve:
In org.apache.dubbo.common.utils.ClassHelper#convertPrimitive we
should check the input String to ensure it is not empty, or a
NumberFormatException will be thrown.
I can easily reproduce this issue with following test case:
@Test
public void testConvertPrimitive() {
Object result = ClassHelper.convertPrimitive(Integer.class, "");
}
[1] https://github.com/apache/incubator-dubbo/pull/3027
On Thu, Dec 27, 2018 at 3:24 AM Imteyaz Khan <kh...@gmail.com> wrote:
>
> Hi all,
> Travis CI are failing currently due to log size. Is it the same issue
> 3052 <https://github.com/apache/incubator-dubbo/issues/3052>?
--
Best Regards！
Huxing
Re: travis ci are failing
Posted by victory <sh...@gmail.com>.
I check this issue.
The metadata is written asynchronously, so getting data return null .
Firstly I will add more sleep time when getting data return null.
If there are still problems， I will add some events to listen the put
action.
Ian Luo <ia...@gmail.com> 于2018年12月28日周五 下午5:21写道：
> I think it is caused by this:
>
> Running org.apache.dubbo.metadata.store.redis.RedisMetadataReportTest
> log4j:WARN No appenders could be found for logger
> (org.apache.dubbo.common.logger.LoggerFactory).
> log4j:WARN Please initialize the log4j system properly.
> log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig
> for more info.
> Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.773
> sec <<< FAILURE! - in
> org.apache.dubbo.metadata.store.redis.RedisMetadataReportTest
>
> testStoreProvider(org.apache.dubbo.metadata.store.redis.RedisMetadataReportTest)
> Time elapsed: 1.253 sec <<< ERROR!
> org.apache.dubbo.rpc.RpcException: Failed to put to redis . cause: null
> at
> org.apache.dubbo.metadata.store.redis.RedisMetadataReportTest.testStoreProvider(RedisMetadataReportTest.java:80)
> Caused by: java.lang.AssertionError
> at
> org.apache.dubbo.metadata.store.redis.RedisMetadataReportTest.testStoreProvider(RedisMetadataReportTest.java:74)
>
>
> -Ian.
>
>
> On Fri, Dec 28, 2018 at 3:05 PM Imteyaz Khan <kh...@gmail.com>
> wrote:
>
> > In travis I am seeing ci are running successfully for jdk1.8 and same is
> > failing for jdak 11. Looking the the log found some test cases are
> failing?
> > Is any one has encountered/seen the same problem?
> >
> >
> >
> >
> https://travis-ci.org/apache/incubator-dubbo/builds/472901130?utm_source=github_status&utm_medium=notification
> >
> > On Fri, Dec 28, 2018 at 10:24 AM Xin Wang <xi...@gmail.com>
> > wrote:
> >
> > > > Is this particular issue solved, without tuning JVM option?
> > >
> > > Yes now ci of master branch passed
> > >
> > > Ian Luo <ia...@gmail.com> 于2018年12月28日周五 上午11:15写道：
> > >
> > > > Is this particular issue solved, without tuning JVM option?
> > > >
> > > > Thanks,
> > > > -Ian.
> > > >
> > > > On Thu, Dec 27, 2018 at 3:59 AM 徐靖峰 <ki...@foxmail.com> wrote:
> > > >
> > > > > I failed twice caused by OutOfMemery，are you the same as me？
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > ------------------ Original ------------------
> > > > > From: Imteyaz Khan <kh...@gmail.com>
> > > > > Date: Thu,Dec 27,2018 3:24 AM
> > > > > To: dev <de...@dubbo.apache.org>
> > > > > Subject: Re: travis ci are failing
> > > > >
> > > > >
> > > > >
> > > > > Hi all,
> > > > > Travis CI are failing currently due to log size. Is it the same
> > > issue
> > > > > 3052 <https://github.com/apache/incubator-dubbo/issues/3052>?
> > > >
> > >
> >
>
--
Best Regard!
cvitory
Re: travis ci are failing
Posted by Ian Luo <ia...@gmail.com>.
I think it is caused by this:
Running org.apache.dubbo.metadata.store.redis.RedisMetadataReportTest
log4j:WARN No appenders could be found for logger
(org.apache.dubbo.common.logger.LoggerFactory).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig
for more info.
Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.773
sec <<< FAILURE! - in
org.apache.dubbo.metadata.store.redis.RedisMetadataReportTest
testStoreProvider(org.apache.dubbo.metadata.store.redis.RedisMetadataReportTest)
Time elapsed: 1.253 sec <<< ERROR!
org.apache.dubbo.rpc.RpcException: Failed to put to redis . cause: null
at org.apache.dubbo.metadata.store.redis.RedisMetadataReportTest.testStoreProvider(RedisMetadataReportTest.java:80)
Caused by: java.lang.AssertionError
at org.apache.dubbo.metadata.store.redis.RedisMetadataReportTest.testStoreProvider(RedisMetadataReportTest.java:74)
-Ian.
On Fri, Dec 28, 2018 at 3:05 PM Imteyaz Khan <kh...@gmail.com> wrote:
> In travis I am seeing ci are running successfully for jdk1.8 and same is
> failing for jdak 11. Looking the the log found some test cases are failing?
> Is any one has encountered/seen the same problem?
>
>
>
> https://travis-ci.org/apache/incubator-dubbo/builds/472901130?utm_source=github_status&utm_medium=notification
>
> On Fri, Dec 28, 2018 at 10:24 AM Xin Wang <xi...@gmail.com>
> wrote:
>
> > > Is this particular issue solved, without tuning JVM option?
> >
> > Yes now ci of master branch passed
> >
> > Ian Luo <ia...@gmail.com> 于2018年12月28日周五 上午11:15写道：
> >
> > > Is this particular issue solved, without tuning JVM option?
> > >
> > > Thanks,
> > > -Ian.
> > >
> > > On Thu, Dec 27, 2018 at 3:59 AM 徐靖峰 <ki...@foxmail.com> wrote:
> > >
> > > > I failed twice caused by OutOfMemery，are you the same as me？
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > ------------------ Original ------------------
> > > > From: Imteyaz Khan <kh...@gmail.com>
> > > > Date: Thu,Dec 27,2018 3:24 AM
> > > > To: dev <de...@dubbo.apache.org>
> > > > Subject: Re: travis ci are failing
> > > >
> > > >
> > > >
> > > > Hi all,
> > > > Travis CI are failing currently due to log size. Is it the same
> > issue
> > > > 3052 <https://github.com/apache/incubator-dubbo/issues/3052>?
> > >
> >
>
Re: travis ci are failing
Posted by Imteyaz Khan <kh...@gmail.com>.
In travis I am seeing ci are running successfully for jdk1.8 and same is
failing for jdak 11. Looking the the log found some test cases are failing?
Is any one has encountered/seen the same problem?
https://travis-ci.org/apache/incubator-dubbo/builds/472901130?utm_source=github_status&utm_medium=notification
On Fri, Dec 28, 2018 at 10:24 AM Xin Wang <xi...@gmail.com> wrote:
> > Is this particular issue solved, without tuning JVM option?
>
> Yes now ci of master branch passed
>
> Ian Luo <ia...@gmail.com> 于2018年12月28日周五 上午11:15写道：
>
> > Is this particular issue solved, without tuning JVM option?
> >
> > Thanks,
> > -Ian.
> >
> > On Thu, Dec 27, 2018 at 3:59 AM 徐靖峰 <ki...@foxmail.com> wrote:
> >
> > > I failed twice caused by OutOfMemery，are you the same as me？
> > >
> > >
> > >
> > >
> > >
> > > ------------------ Original ------------------
> > > From: Imteyaz Khan <kh...@gmail.com>
> > > Date: Thu,Dec 27,2018 3:24 AM
> > > To: dev <de...@dubbo.apache.org>
> > > Subject: Re: travis ci are failing
> > >
> > >
> > >
> > > Hi all,
> > > Travis CI are failing currently due to log size. Is it the same
> issue
> > > 3052 <https://github.com/apache/incubator-dubbo/issues/3052>?
> >
>
Re: travis ci are failing
Posted by Xin Wang <xi...@gmail.com>.
> Is this particular issue solved, without tuning JVM option?
Yes now ci of master branch passed
Ian Luo <ia...@gmail.com> 于2018年12月28日周五 上午11:15写道：
> Is this particular issue solved, without tuning JVM option?
>
> Thanks,
> -Ian.
>
> On Thu, Dec 27, 2018 at 3:59 AM 徐靖峰 <ki...@foxmail.com> wrote:
>
> > I failed twice caused by OutOfMemery，are you the same as me？
> >
> >
> >
> >
> >
> > ------------------ Original ------------------
> > From: Imteyaz Khan <kh...@gmail.com>
> > Date: Thu,Dec 27,2018 3:24 AM
> > To: dev <de...@dubbo.apache.org>
> > Subject: Re: travis ci are failing
> >
> >
> >
> > Hi all,
> > Travis CI are failing currently due to log size. Is it the same issue
> > 3052 <https://github.com/apache/incubator-dubbo/issues/3052>?
>
Re: travis ci are failing
Posted by Ian Luo <ia...@gmail.com>.
Is this particular issue solved, without tuning JVM option?
Thanks,
-Ian.
On Thu, Dec 27, 2018 at 3:59 AM 徐靖峰 <ki...@foxmail.com> wrote:
> I failed twice caused by OutOfMemery，are you the same as me？
>
>
>
>
>
> ------------------ Original ------------------
> From: Imteyaz Khan <kh...@gmail.com>
> Date: Thu,Dec 27,2018 3:24 AM
> To: dev <de...@dubbo.apache.org>
> Subject: Re: travis ci are failing
>
>
>
> Hi all,
> Travis CI are failing currently due to log size. Is it the same issue
> 3052 <https://github.com/apache/incubator-dubbo/issues/3052>?
Re: travis ci are failing
Posted by Huxing Zhang <hu...@apache.org>.
Hi,
On Thu, Dec 27, 2018 at 3:59 AM 徐靖峰 <ki...@foxmail.com> wrote:
>
> I failed twice caused by OutOfMemery，are you the same as me？
I believe they are different, I am looking at this pull request[1]:
Exception in thread "Thread-8" java.lang.OutOfMemoryError: GC overhead
limit exceeded
at org.mockito.internal.invocation.mockref.MockWeakReference.<init>(MockWeakReference.java:20)
at org.mockito.internal.invocation.DefaultInvocationFactory.createInvocation(DefaultInvocationFactory.java:36)
at org.mockito.internal.creation.bytebuddy.MockMethodInterceptor.doIntercept(MockMethodInterceptor.java:63)
at org.mockito.internal.creation.bytebuddy.MockMethodInterceptor.doIntercept(MockMethodInterceptor.java:49)
at org.mockito.internal.creation.bytebuddy.MockMethodInterceptor$DispatcherDefaultingToRealMethod.interceptAbstract(MockMethodInterceptor.java:128)
at com.alibaba.dubbo.rpc.Invoker$MockitoMock$1259520505.getUrl(Unknown Source)
at com.alibaba.dubbo.rpc.cluster.loadbalance.AbstractLoadBalance.getWeight(AbstractLoadBalance.java:50)
at com.alibaba.dubbo.rpc.cluster.loadbalance.RoundRobinLoadBalance.doSelect(RoundRobinLoadBalance.java:105)
I checked the jvm args, -Xmx looks good.
[ [1;31mERROR [m] [1;31mCommand was /bin/sh -c cd
/home/travis/build/apache/incubator-dubbo/dubbo-cluster &&
/usr/lib/jvm/java-8-oracle/jre/bin/java -server -Xms256m -Xmx512m
-XX:MetaspaceSize=64m -XX:MaxMetaspaceSize=128m -Dfile.encoding=UTF-8
-Djava.net.preferIPv4Stack=true
-javaagent:/home/travis/.m2/repository/org/jacoco/org.jacoco.agent/0.8.1/org.jacoco.agent-0.8.1-runtime.jar=destfile=/home/travis/build/apache/incubator-dubbo/dubbo-cluster/target/jacoco.exec
-jar /home/travis/build/apache/incubator-dubbo/dubbo-cluster/target/surefire/surefirebooter6760425011557287290.jar
/home/travis/build/apache/incubator-dubbo/dubbo-cluster/target/surefire/surefire175502514743588813tmp
/home/travis/build/apache/incubator-dubbo/dubbo-cluster/target/surefire/surefire_201077160366611656212tmp
[m
When I check the latest successful build [2], I am surprised that in
the log it says:
Picked up _JAVA_OPTIONS: -Xmx2048m -Xms512m
Looks someone sets the " _JAVA_OPTIONS" to environment variable before
running the UT.
But I did not found it either in Travis Setting or Dubbo source code.
Does anyone know about it ?
[1] https://github.com/apache/incubator-dubbo/pull/3065
[2] https://travis-ci.org/apache/incubator-dubbo/builds/463115930
>
>
>
>
>
> ------------------ Original ------------------
> From: Imteyaz Khan <kh...@gmail.com>
> Date: Thu,Dec 27,2018 3:24 AM
> To: dev <de...@dubbo.apache.org>
> Subject: Re: travis ci are failing
>
>
>
> Hi all,
> Travis CI are failing currently due to log size. Is it the same issue
> 3052 <https://github.com/apache/incubator-dubbo/issues/3052>?
--
Best Regards！
Huxing
Re: travis ci are failing
Posted by 徐靖峰 <ki...@foxmail.com>.
I failed twice caused by OutOfMemery，are you the same as me？
------------------ Original ------------------
From: Imteyaz Khan <kh...@gmail.com>
Date: Thu,Dec 27,2018 3:24 AM
To: dev <de...@dubbo.apache.org>
Subject: Re: travis ci are failing
Hi all,
Travis CI are failing currently due to log size. Is it the same issue
3052 <https://github.com/apache/incubator-dubbo/issues/3052>?