You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/07/26 05:05:55 UTC

[GitHub] [incubator-pegasus] neverchanje commented on a diff in pull request #1079: refactor: Move some common files out of rdsn directory

neverchanje commented on code in PR #1079:
URL: https://github.com/apache/incubator-pegasus/pull/1079#discussion_r929527599


##########
src/rdsn/src/runtime/security/security.thrift:
##########
@@ -15,7 +15,7 @@
 // specific language governing permissions and limitations
 // under the License.
 
-include "../../dsn.thrift"
+include "../../../../../idl/dsn.thrift"

Review Comment:
   dsn.thrift in rdsn/src/ looks fine to me, why did you move it to an outer directory?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org