[GitHub] [struts] lukaszlenart commented on a diff in pull request #688: [WW-5312] Attempt to fix ExecuteAndWaitInterceptor inconsistent processing

["lukaszlenart (via GitHub)" <gi...@apache.org>]

lukaszlenart commented on code in PR #688:
URL: https://github.com/apache/struts/pull/688#discussion_r1200075188


##########
core/src/main/java/org/apache/struts2/interceptor/ExecuteAndWaitInterceptor.java:
##########
@@ -394,7 +404,10 @@ public void init() {
 
     @Override
     public void destroy() {
-        super.destroy();
-        executor.shutdown();
+        try {
+          executor.shutdown();
+        } finally {
+          super.destroy();
+        }

Review Comment:
   👏 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org