You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/27 21:00:41 UTC
[GitHub] [arrow] lidavidm opened a new pull request, #13017: ARROW-15959: [Java][Docs] Improve Java dev experience with IntelliJ
lidavidm opened a new pull request, #13017:
URL: https://github.com/apache/arrow/pull/13017
Update os-maven-plugin to make it work with IntelliJ, and move a test file to the proper directory. Also add some more detailed instructions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #13017: ARROW-15959: [Java][Docs] Improve Java dev experience with IntelliJ
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #13017:
URL: https://github.com/apache/arrow/pull/13017#issuecomment-1115011023
CC @davisusanibar any comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on a diff in pull request #13017: ARROW-15959: [Java][Docs] Improve Java dev experience with IntelliJ
Posted by GitBox <gi...@apache.org>.
davisusanibar commented on code in PR #13017:
URL: https://github.com/apache/arrow/pull/13017#discussion_r863069326
##########
docs/source/developers/java/building.rst:
##########
@@ -171,11 +171,31 @@ IDE Configuration
IntelliJ
--------
-To start working on Arrow in IntelliJ, just open the `java/`
-subdirectory of the Arrow repository.
-
+To start working on Arrow in IntelliJ: build the project once from the command
+line using ``mvn clean install``. Then open the ``java/`` subdirectory of the
+Arrow repository, and update the following settings:
+
+* In the Files tool window, find the path ``vector/target/generated-sources``,
+ right click the directory, and select Mark Directory as > Generated Sources
+ Root. There is no need to mark other generated sources directories, as only
+ the ``vector`` module generates sources.
Review Comment:
If this is needed we need to enforce "to keep a directory marked as a source root after it has been deleted/recreated through": Preferences > Build, Execution, Deployment > Build Tools > Maven > Importing > `Keep source and test folders on project reload`
FYI, I am not able to test this step "Mark Directory as > Generated Sources Root" on my local machine, it finished without errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #13017: ARROW-15959: [Java][Docs] Improve Java dev experience with IntelliJ
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #13017:
URL: https://github.com/apache/arrow/pull/13017#issuecomment-1112334457
Thanks for the feedback.
Re-rendered:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on a diff in pull request #13017: ARROW-15959: [Java][Docs] Improve Java dev experience with IntelliJ
Posted by GitBox <gi...@apache.org>.
davisusanibar commented on code in PR #13017:
URL: https://github.com/apache/arrow/pull/13017#discussion_r862984990
##########
docs/source/developers/java/building.rst:
##########
@@ -171,11 +171,31 @@ IDE Configuration
IntelliJ
--------
-To start working on Arrow in IntelliJ, just open the `java/`
-subdirectory of the Arrow repository.
-
+To start working on Arrow in IntelliJ: build the project once from the command
+line using ``mvn clean install``. Then open the ``java/`` subdirectory of the
+Arrow repository, and update the following settings:
+
+* In the Files tool window, find the path ``vector/target/generated-sources``,
+ right click the directory, and select Mark Directory as > Generated Sources
+ Root. There is no need to mark other generated sources directories, as only
+ the ``vector`` module generates sources.
* For JDK 8, disable the ``error-prone`` profile to build the project successfully.
-* For JDK 11, the project should build successfully with the default profiles.
+* For JDK 11, due to an `IntelliJ bug
+ <https://youtrack.jetbrains.com/issue/IDEA-201168>`__, you must go into
+ Settings > Build, Execution, Deployment > Compiler > Java Compiler and disable
+ "Use '--release' option for cross-compilation (Java 9 and later)". Otherwise
+ you will get an error like "package sun.misc does not exist".
+* You may need to disable the ``linux-netty-native`` profile in the Maven tool
Review Comment:
You may need to disable the ``linux-netty-native`` or ``mac-netty-native`` profile in the Maven tool
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13017: ARROW-15959: [Java][Docs] Improve Java dev experience with IntelliJ
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13017:
URL: https://github.com/apache/arrow/pull/13017#issuecomment-1120168531
Benchmark runs are scheduled for baseline = d8977165d610d3b828eea0923d733cc5a1cf2c4e and contender = 6b32c300e1655b7e8eb2271b581948fb7864af12. 6b32c300e1655b7e8eb2271b581948fb7864af12 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f3ea1867759140d684217209fc9d1f34...fae4c263f423458aa547c726514cac35/)
[Finished :arrow_down:0.43% :arrow_up:0.19%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/774300a28eb645cabecd678130e96117...7942d1042f954611a745895556d81fe5/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/0222e551cf1f4ca39de2783eb4a80be2...6389f93766234704ace4401d6b1a7e64/)
[Finished :arrow_down:0.2% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8021b6a22a204eddb5334f7335328f37...7dcb95ac46bc409fabacbd952fa55f3d/)
Buildkite builds:
[Finished] [`6b32c300` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/688)
[Finished] [`6b32c300` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/685)
[Finished] [`6b32c300` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/674)
[Finished] [`6b32c300` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/690)
[Finished] [`d8977165` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/687)
[Finished] [`d8977165` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/684)
[Finished] [`d8977165` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/673)
[Finished] [`d8977165` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/689)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on a diff in pull request #13017: ARROW-15959: [Java][Docs] Improve Java dev experience with IntelliJ
Posted by GitBox <gi...@apache.org>.
davisusanibar commented on code in PR #13017:
URL: https://github.com/apache/arrow/pull/13017#discussion_r863075168
##########
docs/source/developers/java/building.rst:
##########
@@ -171,11 +171,31 @@ IDE Configuration
IntelliJ
--------
-To start working on Arrow in IntelliJ, just open the `java/`
-subdirectory of the Arrow repository.
-
+To start working on Arrow in IntelliJ: build the project once from the command
+line using ``mvn clean install``. Then open the ``java/`` subdirectory of the
+Arrow repository, and update the following settings:
+
+* In the Files tool window, find the path ``vector/target/generated-sources``,
+ right click the directory, and select Mark Directory as > Generated Sources
+ Root. There is no need to mark other generated sources directories, as only
+ the ``vector`` module generates sources.
Review Comment:
Oh, ok, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed pull request #13017: ARROW-15959: [Java][Docs] Improve Java dev experience with IntelliJ
Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #13017: ARROW-15959: [Java][Docs] Improve Java dev experience with IntelliJ
URL: https://github.com/apache/arrow/pull/13017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #13017: ARROW-15959: [Java][Docs] Improve Java dev experience with IntelliJ
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #13017:
URL: https://github.com/apache/arrow/pull/13017#discussion_r863069903
##########
docs/source/developers/java/building.rst:
##########
@@ -171,11 +171,31 @@ IDE Configuration
IntelliJ
--------
-To start working on Arrow in IntelliJ, just open the `java/`
-subdirectory of the Arrow repository.
-
+To start working on Arrow in IntelliJ: build the project once from the command
+line using ``mvn clean install``. Then open the ``java/`` subdirectory of the
+Arrow repository, and update the following settings:
+
+* In the Files tool window, find the path ``vector/target/generated-sources``,
+ right click the directory, and select Mark Directory as > Generated Sources
+ Root. There is no need to mark other generated sources directories, as only
+ the ``vector`` module generates sources.
Review Comment:
You won't get errors until you open a file that references one of the generated classes or do an _IntelliJ_ build (not a Maven build)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13017: ARROW-15959: [Java][Docs] Improve Java dev experience with IntelliJ
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13017:
URL: https://github.com/apache/arrow/pull/13017#issuecomment-1111479742
https://issues.apache.org/jira/browse/ARROW-15959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lwhite1 commented on a diff in pull request #13017: ARROW-15959: [Java][Docs] Improve Java dev experience with IntelliJ
Posted by GitBox <gi...@apache.org>.
lwhite1 commented on code in PR #13017:
URL: https://github.com/apache/arrow/pull/13017#discussion_r860953213
##########
docs/source/developers/java/building.rst:
##########
@@ -171,11 +171,30 @@ IDE Configuration
IntelliJ
--------
-To start working on Arrow in IntelliJ, just open the `java/`
-subdirectory of the Arrow repository.
+To start working on Arrow in IntelliJ: build the project once from the command
+line using ``mvn clean install``. Then open the ``java/`` subdirectory of the
+Arrow repository, and update the following settings:
+* In the Files tool window, find the path ``vector/target/generated-sources``,
+ right click the directory, and select Mark Directory as > Generated Sources
+ Root.
Review Comment:
Does it make sense to say that there's no need to mark the other generated-sourced folders as Generated Sources Root? There are, I think, five folders (under tools, plasma, format, compression, and algorithm) that are generated, but they contain only empty "annotation" folders, at least in my current build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org