You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zhangstar333 (via GitHub)" <gi...@apache.org> on 2023/05/05 12:51:24 UTC
[GitHub] [doris] zhangstar333 opened a new pull request, #19320: [vectorized](function) fix array_map funtion return type maybe get wrong
zhangstar333 opened a new pull request, #19320:
URL: https://github.com/apache/doris/pull/19320
# Proposed changes
when get function from functionSet, maybe can't change it's any attribute.
but array_map function return type depend on lambda Expr return type,
so new Function object for it.
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee merged pull request #19320: [vectorized](function) fix array_map funtion return type maybe get wrong
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee merged PR #19320:
URL: https://github.com/apache/doris/pull/19320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhangstar333 commented on pull request #19320: [vectorized](function) fix array_map funtion return type maybe get wrong
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #19320:
URL: https://github.com/apache/doris/pull/19320#issuecomment-1541197295
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhangstar333 commented on pull request #19320: [vectorized](function) fix array_map funtion return type maybe get wrong
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #19320:
URL: https://github.com/apache/doris/pull/19320#issuecomment-1548898809
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhangstar333 commented on pull request #19320: [vectorized](function) fix array_map funtion return type maybe get wrong
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #19320:
URL: https://github.com/apache/doris/pull/19320#issuecomment-1557283234
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #19320: [vectorized](function) fix array_map funtion return type maybe get wrong
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #19320:
URL: https://github.com/apache/doris/pull/19320#discussion_r1186588460
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnRefExpr.java:
##########
@@ -83,7 +83,7 @@ protected void analyzeImpl(Analyzer analyzer) throws AnalysisException {
@Override
protected String toSqlImpl() {
- return columnName + "(" + columnId + ")";
+ return columnName;
Review Comment:
why change the code ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhangstar333 commented on pull request #19320: [vectorized](function) fix array_map funtion return type maybe get wrong
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #19320:
URL: https://github.com/apache/doris/pull/19320#issuecomment-1537605099
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #19320: [vectorized](function) fix array_map funtion return type maybe get wrong
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #19320:
URL: https://github.com/apache/doris/pull/19320#discussion_r1186591879
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/LambdaFunctionCallExpr.java:
##########
@@ -97,14 +99,17 @@ public void analyzeImpl(Analyzer analyzer) throws AnalysisException {
this.setChild(0, lastChild);
}
- fn = getBuiltinFunction(fnName.getFunction(), argTypes,
- Function.CompareMode.IS_NONSTRICT_SUPERTYPE_OF);
Expr lambda = this.children.get(0);
+ if (!(lambda instanceof LambdaFunctionExpr)) {
+ throw new AnalysisException("array_map must use lambda as first input params, now is" +
+ lambda.debugString());
+ }
+ fn = new Function(fnName, Arrays.asList(argTypes), ArrayType.create(lambda.getChild(0).getType(), true),
+ true, true, NullableMode.DEPEND_ON_ARGUMENT);
if (fn == null) {
Review Comment:
delete the check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #19320: [vectorized](function) fix array_map funtion return type maybe get wrong
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #19320:
URL: https://github.com/apache/doris/pull/19320#discussion_r1186589395
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/LambdaFunctionCallExpr.java:
##########
@@ -97,14 +99,17 @@ public void analyzeImpl(Analyzer analyzer) throws AnalysisException {
this.setChild(0, lastChild);
}
- fn = getBuiltinFunction(fnName.getFunction(), argTypes,
Review Comment:
why not do clone here ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhangstar333 commented on pull request #19320: [vectorized](function) fix array_map funtion return type maybe get wrong
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #19320:
URL: https://github.com/apache/doris/pull/19320#issuecomment-1536222476
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #19320: [vectorized](function) fix array_map funtion return type maybe get wrong
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #19320:
URL: https://github.com/apache/doris/pull/19320#discussion_r1186596264
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/LambdaFunctionCallExpr.java:
##########
@@ -199,17 +191,12 @@ public void analyzeImpl(Analyzer analyzer) throws AnalysisException {
}
fn = getBuiltinFunction(fnName.getFunction(), argTypes,
Function.CompareMode.IS_NONSTRICT_SUPERTYPE_OF);
- if (fn == null) {
Review Comment:
here should not delete ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhangstar333 commented on pull request #19320: [vectorized](function) fix array_map funtion return type maybe get wrong
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #19320:
URL: https://github.com/apache/doris/pull/19320#issuecomment-1541558938
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhangstar333 commented on pull request #19320: [vectorized](function) fix array_map funtion return type maybe get wrong
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #19320:
URL: https://github.com/apache/doris/pull/19320#issuecomment-1536965835
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org