You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/08/06 06:39:03 UTC

[GitHub] [flink] danny0405 commented on a change in pull request #9361: [FLINK-13540] DDL do not support properties key that contains number …

danny0405 commented on a change in pull request #9361: [FLINK-13540] DDL do not support properties key that contains number …
URL: https://github.com/apache/flink/pull/9361#discussion_r310901122
 
 

 ##########
 File path: flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl
 ##########
 @@ -115,18 +115,18 @@ void UniqueKey(List<SqlNodeList> list) :
     }
 }
 
-SqlNode PropertyValue() :
+SqlNode TableOption() :
 {
-    SqlIdentifier key;
+    SqlNode key;
 
 Review comment:
   The `StringLiteral()`'s return type is `SalNode`, i suggest to keep the type as it is(do not force type cast in parser), we have a type cast in `TableOption`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services